You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/02 15:31:39 UTC

[GitHub] [beam] damccorm commented on pull request #17813: [BEAM-14546] Fix errant pass for empty collections in Count

damccorm commented on PR #17813:
URL: https://github.com/apache/beam/pull/17813#issuecomment-1145001536

   The portable failure looks legit as well:
   
   ```
   11:01:07 2022/06/02 14:58:41 2022-06-02 14:58:41. (26): Traceback (most recent call last):
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/local_job_service.py", line 275, in _run_job
   11:01:07     self.result = self._invoke_runner()
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/local_job_service.py", line 297, in _invoke_runner
   11:01:07     return fn_runner.FnApiRunner(
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 208, in run_via_runner_api
   11:01:07     return self.run_stages(stage_context, stages)
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 408, in run_stages
   11:01:07     bundle_results = self._execute_bundle(
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 736, in _execute_bundle
   11:01:07     self._run_bundle(
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 965, in _run_bundle
   11:01:07     result, splits = bundle_manager.process_bundle(
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 1314, in process_bundle
   11:01:07     raise RuntimeError(result.error)
   11:01:07 RuntimeError: process bundle failed for instruction bundle_15 using plan 2 : while executing Process for Plan[2]:
   11:01:07 2: ParDo[passert.nonEmptyFn] Out:[]
   11:01:07 1: DataSource[S[passert.Count(out)/passert.NonEmpty/Impulse@localhost:38365], i0] Coder:W;c0_windowed<bytes;c0>!GWC Out:2
   11:01:07 	caused by:
   11:01:07 DoFn[UID:2, PID:passert.Count(out)/passert.NonEmpty/passert.nonEmptyFn, Name: github.com/apache/beam/sdks/v2/go/pkg/beam/testing/passert.nonEmptyFn] failed:
   11:01:07 PCollection is empty, want non-empty collection
   11:01:07 2022/06/02 14:58:41 2022-06-02 14:58:41. (27): Error running pipeline.
   11:01:07 Traceback (most recent call last):
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/local_job_service.py", line 275, in _run_job
   11:01:07     self.result = self._invoke_runner()
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/local_job_service.py", line 297, in _invoke_runner
   11:01:07     return fn_runner.FnApiRunner(
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 208, in run_via_runner_api
   11:01:07     return self.run_stages(stage_context, stages)
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 408, in run_stages
   11:01:07     bundle_results = self._execute_bundle(
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 736, in _execute_bundle
   11:01:07     self._run_bundle(
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 965, in _run_bundle
   11:01:07     result, splits = bundle_manager.process_bundle(
   11:01:07   File "/home/jenkins/jenkins-slave/workspace/beam_PreCommit_GoPortable_Commit/src/sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py", line 1314, in process_bundle
   11:01:07     raise RuntimeError(result.error)
   11:01:07 RuntimeError: process bundle failed for instruction bundle_15 using plan 2 : while executing Process for Plan[2]:
   11:01:07 2: ParDo[passert.nonEmptyFn] Out:[]
   11:01:07 1: DataSource[S[passert.Count(out)/passert.NonEmpty/Impulse@localhost:38365], i0] Coder:W;c0_windowed<bytes;c0>!GWC Out:2
   11:01:07 	caused by:
   11:01:07 DoFn[UID:2, PID:passert.Count(out)/passert.NonEmpty/passert.nonEmptyFn, Name: github.com/apache/beam/sdks/v2/go/pkg/beam/testing/passert.nonEmptyFn] failed:
   11:01:07 PCollection is empty, want non-empty collection
   11:01:07 2022/06/02 14:58:41 Job state: FAILED
   11:01:07     ptest.go:108: Failed to execute job: job go-testsimplepipeline-e0c742f9-4ac7-4f8f-9eff-73c54d6d8617 failed
   11:01:07 --- FAIL: TestSimplePipeline (12.70s)
   ```
   
   Not sure if the test is broken (and erroneously passing) or if something here is broken


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org