[GitHub] [nifi] exceptionfactory commented on a change in pull request #5355: NIFI-9181 Prevent unwanted test artifacts in Windows builds

[GitBox <gi...@apache.org>]

exceptionfactory commented on a change in pull request #5355:
URL: https://github.com/apache/nifi/pull/5355#discussion_r702976979



##########
File path: nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/test/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScriptTest.java
##########
@@ -105,7 +105,7 @@ public static void setupBeforeClass() throws Exception {
         Assume.assumeTrue("Test only runs on *nix", !SystemUtils.IS_OS_WINDOWS);
         FileUtils.copyDirectory(new File("src/test/resources"), new File("target/test/resources"));
         //prepare database connection
-        System.setProperty("derby.stream.error.file", "target/derby.log");
+        System.setProperty("derby.stream.error.file", "target" + File.separator + "derby.log");

Review comment:
       According to line 105, this test class does not run on Windows. Is there some other possible cause of `derby.log` being created in the `nifi-groovyx-processors` directory?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org