You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/01/09 19:56:47 UTC
[GitHub] [orc] williamhyun opened a new pull request #615: Run mvn checkstyle:check in GitHub action.
williamhyun opened a new pull request #615:
URL: https://github.com/apache/orc/pull/615
<!--
Thanks for sending a pull request! Here are some tips for you:
1. File a JIRA issue first and use it as a prefix of your PR title, e.g., `ORC-001: Fix ABC`.
2. Use your PR title to summarize what this PR proposes instead of describing the problem.
3. Make PR title and description complete because these will be the permanent commit log.
4. If possible, provide a concise and reproducible example to reproduce the issue for a faster review.
5. If the PR is unfinished, use GitHub PR Draft feature.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #615: ORC-720: Run mvn checkstyle:check in GitHub action.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #615:
URL: https://github.com/apache/orc/pull/615#issuecomment-757364869
This is merged via https://github.com/apache/orc/commit/d741a36a0049db0a081091922f4ca7a61bee6d78
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #615: ORC-720: Run mvn checkstyle:check in GitHub action.
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #615:
URL: https://github.com/apache/orc/pull/615#issuecomment-757367465
Sure I will create an umbrella JIRA @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #615: ORC-720: Run mvn checkstyle:check in GitHub action.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #615:
URL: https://github.com/apache/orc/pull/615#issuecomment-757366710
While you are working on this, could you make an umbrella JIRA and put your subtask JIRAs under that JIRA, please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun edited a comment on pull request #615: ORC-720: Run mvn checkstyle:check in GitHub action.
Posted by GitBox <gi...@apache.org>.
williamhyun edited a comment on pull request #615:
URL: https://github.com/apache/orc/pull/615#issuecomment-757367465
Sure I will create an umbrella JIRA @dongjoon-hyun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #615: ORC-720: Run mvn checkstyle:check in GitHub action.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #615:
URL: https://github.com/apache/orc/pull/615#issuecomment-757364724
From the GitHub Action log, I verified the following.
```
2482 [INFO] --- maven-checkstyle-plugin:3.1.1:check (default-cli) @ orc-examples ---
2483
[INFO] You have 0 Checkstyle violations.
2484
[INFO] ------------------------------------------------------------------------
2485
[INFO] Reactor Summary for Apache ORC 1.7.0-SNAPSHOT:
2486
[INFO]
2487
[INFO] Apache ORC ......................................... SUCCESS [ 3.336 s]
2488
[INFO] ORC Shims .......................................... SUCCESS [ 0.053 s]
2489
[INFO] ORC Core ........................................... SUCCESS [ 0.135 s]
2490
[INFO] ORC MapReduce ...................................... SUCCESS [ 0.034 s]
2491
[INFO] ORC Tools .......................................... SUCCESS [ 0.046 s]
2492
[INFO] ORC Examples ....................................... SUCCESS [ 0.023 s]
2493
[INFO] ------------------------------------------------------------------------
2494
[INFO] BUILD SUCCESS
2495
[INFO] ------------------------------------------------------------------------
2496
[INFO] Total time: 4.059 s
2497
[INFO] Finished at: 2021-01-09T20:08:53Z
2498
[INFO] ------------------------------------------------------------------------
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #615: ORC-720: Run mvn checkstyle:check in GitHub action.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #615:
URL: https://github.com/apache/orc/pull/615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun commented on pull request #615: ORC-720: Run mvn checkstyle:check in GitHub action.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #615:
URL: https://github.com/apache/orc/pull/615#issuecomment-757364724
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun edited a comment on pull request #615: ORC-720: Run mvn checkstyle:check in GitHub action.
Posted by GitBox <gi...@apache.org>.
williamhyun edited a comment on pull request #615:
URL: https://github.com/apache/orc/pull/615#issuecomment-757367465
Sure I will create an umbrella JIRA @dongjoon-hyun.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] dongjoon-hyun closed pull request #615: ORC-720: Run mvn checkstyle:check in GitHub action.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #615:
URL: https://github.com/apache/orc/pull/615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] williamhyun commented on pull request #615: ORC-720: Run mvn checkstyle:check in GitHub action.
Posted by GitBox <gi...@apache.org>.
williamhyun commented on pull request #615:
URL: https://github.com/apache/orc/pull/615#issuecomment-757367465
Sure I will create an umbrella JIRA @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org