[GitHub] [netbeans] BradWalker commented on pull request #5332: Improved collections usage. Part 1

["BradWalker (via GitHub)" <gi...@apache.org>]

BradWalker commented on PR #5332:
URL: https://github.com/apache/netbeans/pull/5332#issuecomment-1399174804

   The large number of files is not a small amount of work to review. I've done a lot of "simple" code cleanup in the past. My work was clearly tied to the removal of warning messages.  These changes don't seem to really be tied to a problem or issue. They appear to me to be code clean just for the sake of code cleanup. 
   
   When I did code clean up in the past here are some reminders that I was always telling myself:
   1 - is this work too large to be easily reviewed, if so break it down
   2 - i always tried to pace myself, that way i wasn't overwhelming the team with code reviews
   3 - i often had a a review ready to go but did not submit it because wanted to wait for the previous one to be approved - again pacing myself
   4 - i tried to listen to the feedback that i was getting, both positive and negative
   
   It's always a good thing to ask oneself "what am I trying to accomplish"..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists