[jira] [Comment Edited] (CASSANDRA-6075) The token function should allow column identifiers in the correct order only

["Aleksey Yeschenko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145777#comment-14145777 ] 

Aleksey Yeschenko edited comment on CASSANDRA-6075 at 9/24/14 2:10 AM:
-----------------------------------------------------------------------

Fixed in https://github.com/apache/cassandra/commit/b1166c09983b1678cbc4b241f1da860930c571a5

Used Guava's Iterators#cycle() instead of the null/hasnext check, and removed the (if cfDef.partitionKeyCount() > 0) condition, which is always true.

Thanks.


was (Author: iamaleksey):
Fixed in https://github.com/apache/cassandra/commit/b1166c09983b1678cbc4b241f1da860930c571a5

Used Guava's Itrator#cycle() instead of the null/hasnext check, and removed the (if cfDef.partitionKeyCount() > 0) condition, which is always true.

Thanks.

> The token function should allow column identifiers in the correct order only
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-6075
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-6075
>             Project: Cassandra
>          Issue Type: Bug
>         Environment: Cassandra 1.2.9
>            Reporter: Michaël Figuière
>            Assignee: Benjamin Lerer
>            Priority: Minor
>              Labels: cql
>             Fix For: 2.0.11, 2.1.1
>
>         Attachments: 6075-fix-v2.txt, CASSANDRA-2.0-6075-PART2.txt, CASSANDRA-2.1-6075-PART2.txt, CASSANDRA-2.1-6075.txt, CASSANDRA-6075.txt
>
>
> Given the following table:
> {code}
> CREATE TABLE t1 (a int, b text, PRIMARY KEY ((a, b)));
> {code}
> The following request returns an error in cqlsh as literal arguments order is incorrect:
> {code}
> SELECT * FROM t1 WHERE token(a, b) > token('s', 1);
> Bad Request: Type error: 's' cannot be passed as argument 0 of function token of type int
> {code}
> But surprisingly if we provide the column identifier arguments in the wrong order no error is returned:
> {code}
> SELECT * FROM t1 WHERE token(a, b) > token(1, 'a'); // correct order is valid
> SELECT * FROM t1 WHERE token(b, a) > token(1, 'a'); // incorrect order is valid as well
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)