You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/19 07:59:55 UTC
[GitHub] [shardingsphere] tuichenchuxin opened a new pull request #14897: Support alter foregin data wrapper for postgresql
tuichenchuxin opened a new pull request #14897:
URL: https://github.com/apache/shardingsphere/pull/14897
ref #14015.
Changes proposed in this pull request:
- Support alter foregin data wrapper for postgresql
- add test case
- remove unsupported cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #14897: Support alter foregin data wrapper for postgresql
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on a change in pull request #14897:
URL: https://github.com/apache/shardingsphere/pull/14897#discussion_r787501166
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/ddl/alter-foreign-data-wrapper.xml
##########
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<sql-parser-test-cases>
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case1" />
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case2" />
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case3" />
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case4" />
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case5" />
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case6" />
Review comment:
@tuichenchuxin Can we rename `sql-case-id` with more meaningful name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on pull request #14897: Support alter foregin data wrapper for postgresql
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on pull request #14897:
URL: https://github.com/apache/shardingsphere/pull/14897#issuecomment-1017159986
> @tuichenchuxin Please solve code conflict.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on pull request #14897: Support alter foregin data wrapper for postgresql
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on pull request #14897:
URL: https://github.com/apache/shardingsphere/pull/14897#issuecomment-1016402197
@tuichenchuxin Please solve code conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tuichenchuxin commented on a change in pull request #14897: Support alter foregin data wrapper for postgresql
Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on a change in pull request #14897:
URL: https://github.com/apache/shardingsphere/pull/14897#discussion_r787598169
##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/resources/case/ddl/alter-foreign-data-wrapper.xml
##########
@@ -0,0 +1,35 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<sql-parser-test-cases>
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case1" />
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case2" />
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case3" />
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case4" />
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case5" />
+ <alter-foreign-data-wrapper sql-case-id="alter_foreign_data_wrapper_case6" />
Review comment:
ok,done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #14897: Support alter foregin data wrapper for postgresql
Posted by GitBox <gi...@apache.org>.
strongduanmu merged pull request #14897:
URL: https://github.com/apache/shardingsphere/pull/14897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org