Re: [PR] [cgroups2] Introduce API to set a soft memory limit. [mesos]

["bmahler (via GitHub)" <gi...@apache.org>]

bmahler commented on code in PR #559:
URL: https://github.com/apache/mesos/pull/559#discussion_r1567736625


##########
src/linux/cgroups2.cpp:
##########
@@ -795,6 +795,7 @@ Result<Bytes> parse_bytelimit(const string& value)
 namespace control {
 
 const string CURRENT = "memory.current";
+const string HIGH = "memory.high";
 const string MAX = "memory.max";
 const string MIN = "memory.min";

Review Comment:
   we can add all the control functionality here, but it looks like we're only going to use memory.low and memory.max: https://facebookmicrosites.github.io/cgroup2/docs/memory-controller.html
   
   How crun handles requests vs limits:
   https://github.com/containers/crun/blob/68df0832427e692c705bd3485719174091b37cb5/crun.1.md#memory-controller
   
   This is how mesos would do request vs limits as well for burstable containers:
   https://mesos.apache.org/documentation/latest/running-workloads/#resource-requests-and-limits



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org