You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/23 06:23:40 UTC

[GitHub] [apisix] imjoey edited a comment on issue #2490: discuss: In the request of the `hmac-auth` plugin, remove the request header related to the plugin

imjoey edited a comment on issue #2490:
URL: https://github.com/apache/apisix/issues/2490#issuecomment-714950523


   > > > X-HMAC-ACCESS-KEY,
   > > > X-HMAC-SIGNATURE,
   > > > X-HMAC-ALGORITHM,
   > > > X-HMAC-SIGNED-HEADERS,
   > > > Date
   > > 
   > > 
   > > I think we can remove `X-HMAC-SIGNATURE`, `X-HMAC-ALGORITHM` and `X-HMAC-SIGNED-HEADERS`.
   > > And we should keep `X-HMAC-ACCESS-KEY` and `Date`. what do you think? @gxthrj @Firstsawyou
   > 
   > Why do we need to keep the `date`, upstream should not need it. I don't understand here?
   
   @Firstsawyou  `Date` is a general and commonly used HTTP header, so we would better not remove it beforehand from the request sent to upstreams.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org