svn commit: r1723718 - in /sling/trunk/bundles/commons/metrics/src: main/java/org/apache/sling/commons/metrics/ main/java/org/apache/sling/commons/metrics/internal/ test/java/org/apache/sling/commons/metrics/internal/

[ch...@apache.org]

Author: chetanm
Date: Fri Jan  8 12:35:50 2016
New Revision: 1723718

URL: http://svn.apache.org/viewvc?rev=1723718&view=rev
Log:
SLING-4080 - API to capture/measure application-level metrics

Change the method names as per suggestion by Oliver Lietz!

Modified:
    sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/Counter.java
    sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/NoopMetric.java
    sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/CounterImpl.java
    sling/trunk/bundles/commons/metrics/src/test/java/org/apache/sling/commons/metrics/internal/MetricWrapperTest.java

Modified: sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/Counter.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/Counter.java?rev=1723718&r1=1723717&r2=1723718&view=diff
==============================================================================
--- sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/Counter.java (original)
+++ sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/Counter.java Fri Jan  8 12:35:50 2016
@@ -29,24 +29,24 @@ public interface Counter extends Countin
     /**
      * Increment the counter by one.
      */
-    void inc();
+    void increment();
 
     /**
      * Decrement the counter by one.
      */
-    void dec();
+    void decrement();
 
     /**
      * Increment the counter by {@code n}.
      *
      * @param n the amount by which the counter will be increased
      */
-    void inc(long n);
+    void increment(long n);
 
     /**
      * Decrement the counter by {@code n}.
      *
      * @param n the amount by which the counter will be decreased
      */
-    void dec(long n);
+    void decrement(long n);
 }

Modified: sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/NoopMetric.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/NoopMetric.java?rev=1723718&r1=1723717&r2=1723718&view=diff
==============================================================================
--- sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/NoopMetric.java (original)
+++ sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/NoopMetric.java Fri Jan  8 12:35:50 2016
@@ -30,22 +30,22 @@ enum NoopMetric implements Counter, Hist
     }
 
     @Override
-    public void inc() {
+    public void increment() {
 
     }
 
     @Override
-    public void dec() {
+    public void decrement() {
 
     }
 
     @Override
-    public void inc(long n) {
+    public void increment(long n) {
 
     }
 
     @Override
-    public void dec(long n) {
+    public void decrement(long n) {
 
     }
 

Modified: sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/CounterImpl.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/CounterImpl.java?rev=1723718&r1=1723717&r2=1723718&view=diff
==============================================================================
--- sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/CounterImpl.java (original)
+++ sling/trunk/bundles/commons/metrics/src/main/java/org/apache/sling/commons/metrics/internal/CounterImpl.java Fri Jan  8 12:35:50 2016
@@ -30,22 +30,22 @@ final class CounterImpl implements Count
     }
 
     @Override
-    public void inc() {
+    public void increment() {
         counter.inc();
     }
 
     @Override
-    public void dec() {
+    public void decrement() {
         counter.dec();
     }
 
     @Override
-    public void inc(long n) {
+    public void increment(long n) {
         counter.inc(n);
     }
 
     @Override
-    public void dec(long n) {
+    public void decrement(long n) {
         counter.dec(n);
     }
 

Modified: sling/trunk/bundles/commons/metrics/src/test/java/org/apache/sling/commons/metrics/internal/MetricWrapperTest.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/commons/metrics/src/test/java/org/apache/sling/commons/metrics/internal/MetricWrapperTest.java?rev=1723718&r1=1723717&r2=1723718&view=diff
==============================================================================
--- sling/trunk/bundles/commons/metrics/src/test/java/org/apache/sling/commons/metrics/internal/MetricWrapperTest.java (original)
+++ sling/trunk/bundles/commons/metrics/src/test/java/org/apache/sling/commons/metrics/internal/MetricWrapperTest.java Fri Jan  8 12:35:50 2016
@@ -40,24 +40,24 @@ public class MetricWrapperTest {
         Counter counter = registry.counter("test");
         CounterImpl counterStats = new CounterImpl(counter);
 
-        counterStats.inc();
+        counterStats.increment();
         assertEquals(1, counterStats.getCount());
         assertEquals(1, counter.getCount());
         assertEquals(1, counterStats.getCount());
 
-        counterStats.inc();
-        counterStats.inc();
+        counterStats.increment();
+        counterStats.increment();
         assertEquals(3, counterStats.getCount());
 
-        counterStats.dec();
+        counterStats.decrement();
         assertEquals(2, counterStats.getCount());
         assertEquals(2, counter.getCount());
 
-        counterStats.inc(7);
+        counterStats.increment(7);
         assertEquals(9, counterStats.getCount());
         assertEquals(9, counter.getCount());
 
-        counterStats.dec(5);
+        counterStats.decrement(5);
         assertEquals(4, counterStats.getCount());
         assertEquals(4, counter.getCount());