[GitHub] [beam] aghajani commented on a change in pull request #15951: [BEAM-13171] Support for stopReadTime on KafkaIO SDF

[GitBox <gi...@apache.org>]

aghajani commented on a change in pull request #15951:
URL: https://github.com/apache/beam/pull/15951#discussion_r757384603



##########
File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java
##########
@@ -338,6 +355,9 @@ public ProcessContinuation processElement(
         // When there are no records available for the current TopicPartition, self-checkpoint
         // and move to process the next element.
         if (rawRecords.isEmpty()) {
+          if (expectedOffset > endOffset) {

Review comment:
       Thanks for the comment, after putting more thought to this, I think it does not make sense to check for the scenario at all since we are getting the endOffset from Kafka Client itself using stopReadTime (will throw exception if no such offset be found). So the waiting scenario would never happen. Just removed the checking section.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org