You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "adonis0147 (via GitHub)" <gi...@apache.org> on 2023/04/14 10:02:32 UTC
[GitHub] [doris] adonis0147 opened a new pull request, #18681: Daft
adonis0147 opened a new pull request, #18681:
URL: https://github.com/apache/doris/pull/18681
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18681: Daft
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1508273339
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #18681: [chore](build) Use include-what-you-use to optimize includes
Posted by "BiteTheDDDDt (via GitHub)" <gi...@apache.org>.
BiteTheDDDDt merged PR #18681:
URL: https://github.com/apache/doris/pull/18681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18681: Daft
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #18681:
URL: https://github.com/apache/doris/pull/18681#discussion_r1167687358
##########
be/src/geo/wkt_parse.cpp:
##########
@@ -17,9 +17,10 @@
#include "geo/wkt_parse.h"
-#include "geo/geo_types.h"
#include "geo/wkt_parse_ctx.h"
+#include "geo/wkt_parse_type.h" // IWYU pragma: keep
#include "geo/wkt_yacc.y.hpp"
Review Comment:
warning: 'geo/wkt_yacc.y.hpp' file not found [clang-diagnostic-error]
```cpp
#include "geo/wkt_yacc.y.hpp"
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: [chore](build) Use include-what-you-use to optimize includes
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1510590689
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: Daft
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1509765580
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: Daft
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1509867357
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: Daft
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1509893472
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18681: Daft
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #18681:
URL: https://github.com/apache/doris/pull/18681#discussion_r1167620439
##########
be/src/common/daemon.cpp:
##########
@@ -17,29 +17,45 @@
#include "common/daemon.h"
+#include <bits/chrono.h>
Review Comment:
warning: 'bits/chrono.h' file not found [clang-diagnostic-error]
```cpp
#include <bits/chrono.h>
^
```
##########
be/src/agent/task_worker_pool.cpp:
##########
@@ -17,46 +17,66 @@
#include "agent/task_worker_pool.h"
+#include <bits/chrono.h>
Review Comment:
warning: 'bits/chrono.h' file not found [clang-diagnostic-error]
```cpp
#include <bits/chrono.h>
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: Daft
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1510028903
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: [chore](build) Use include-what-you-use to optimize includes
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1510409162
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: [chore](build) Use include-what-you-use to optimize includes
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1510390893
run p1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18681: Daft
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #18681:
URL: https://github.com/apache/doris/pull/18681#discussion_r1167574323
##########
be/src/olap/match_predicate.h:
##########
@@ -18,10 +18,11 @@
#ifndef DORIS_BE_SRC_QUERY_EXPRS_MATCH_PREDICATE_H
#define DORIS_BE_SRC_QUERY_EXPRS_MATCH_PREDICATE_H
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DORIS_BE_SRC_QUERY_EXPRS_MATCH_PREDICATE_H
^
```
##########
be/src/olap/task/engine_batch_load_task.h:
##########
@@ -18,12 +18,13 @@
#ifndef DORIS_BE_SRC_OLAP_TASK_ENGINE_BATCH_LOAD_TASK_H
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_BATCH_LOAD_TASK_H
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_BATCH_LOAD_TASK_H
^
```
##########
be/src/vec/functions/function_java_udf.h:
##########
@@ -17,9 +17,9 @@
#pragma once
+#include <gen_cpp/Exprs_types.h>
#include <jni.h>
Review Comment:
warning: 'jni.h' file not found [clang-diagnostic-error]
```cpp
#include <jni.h>
^
```
##########
be/src/olap/rowset/rowset_factory.h:
##########
@@ -18,7 +18,8 @@
#ifndef DORIS_BE_SRC_OLAP_ROWSET_FACTORY_H
#define DORIS_BE_SRC_OLAP_ROWSET_FACTORY_H
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DORIS_BE_SRC_OLAP_ROWSET_FACTORY_H
^
```
##########
be/src/tools/meta_tool.cpp:
##########
@@ -15,6 +15,8 @@
// specific language governing permissions and limitations
// under the License.
+#include <gen_cpp/olap_file.pb.h>
Review Comment:
warning: 'gen_cpp/olap_file.pb.h' file not found [clang-diagnostic-error]
```cpp
#include <gen_cpp/olap_file.pb.h>
^
```
##########
be/src/olap/task/engine_checksum_task.h:
##########
@@ -18,7 +18,8 @@
#ifndef DORIS_BE_SRC_OLAP_TASK_ENGINE_CHECKSUM_TASK_H
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_CHECKSUM_TASK_H
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_CHECKSUM_TASK_H
^
```
##########
be/src/olap/task/engine_storage_migration_task.h:
##########
@@ -18,7 +18,8 @@
#ifndef DORIS_BE_SRC_OLAP_TASK_ENGINE_STORAGE_MIGRATION_TASK_H
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_STORAGE_MIGRATION_TASK_H
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_STORAGE_MIGRATION_TASK_H
^
```
##########
be/src/olap/rowset/rowset_meta.h:
##########
@@ -18,12 +18,13 @@
#ifndef DORIS_BE_SRC_OLAP_ROWSET_ROWSET_META_H
#define DORIS_BE_SRC_OLAP_ROWSET_ROWSET_META_H
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DORIS_BE_SRC_OLAP_ROWSET_ROWSET_META_H
^
```
##########
be/src/olap/task/engine_publish_version_task.h:
##########
@@ -18,7 +18,8 @@
#ifndef DORIS_BE_SRC_OLAP_TASK_ENGINE_PUBLISH_VERSION_TASK_H
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_PUBLISH_VERSION_TASK_H
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_PUBLISH_VERSION_TASK_H
^
```
##########
be/src/olap/task/engine_clone_task.h:
##########
@@ -18,11 +18,12 @@
#ifndef DORIS_BE_SRC_OLAP_TASK_ENGINE_CLONE_TASK_H
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_CLONE_TASK_H
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DORIS_BE_SRC_OLAP_TASK_ENGINE_CLONE_TASK_H
^
```
##########
be/src/olap/rowset/rowset_reader.h:
##########
@@ -18,10 +18,11 @@
#ifndef DORIS_BE_SRC_OLAP_ROWSET_ROWSET_READER_H
#define DORIS_BE_SRC_OLAP_ROWSET_ROWSET_READER_H
Review Comment:
warning: macro is not used [clang-diagnostic-unused-macros]
```cpp
#define DORIS_BE_SRC_OLAP_ROWSET_ROWSET_READER_H
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: Daft
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1508266603
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: [chore](build) Use include-what-you-use to optimize includes
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1510535628
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: [chore](build) Use include-what-you-use to optimize includes
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1510238126
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: [chore](build) Use include-what-you-use to optimize includes
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1510429836
run clickbench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18681: Daft
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1508464620
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.81 seconds
stream load tsv: 426 seconds loaded 74807831229 Bytes, about 167 MB/s
stream load json: 23 seconds loaded 2358488459 Bytes, about 97 MB/s
stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230414125642_clickbench_pr_129197.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #18681: Daft
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on PR #18681:
URL: https://github.com/apache/doris/pull/18681#issuecomment-1510031623
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org