You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "dbalek (via GitHub)" <gi...@apache.org> on 2023/05/18 16:18:51 UTC
[GitHub] [netbeans] dbalek opened a new pull request, #5963: VSCode: Various code completion enhancments.
dbalek opened a new pull request, #5963:
URL: https://github.com/apache/netbeans/pull/5963
Couple of enhancements to VSCode code completion:
- Parameter names in lambda expressions should be based on type instead of name of the corresponding type parameters
- Hovers for local variables and parameter should provide basic info on var declaration
- Links in code completion documentation and hovers should be resolved to web URLs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5963: VSCode: Various code completion enhancements.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #5963:
URL: https://github.com/apache/netbeans/pull/5963#discussion_r1198846346
##########
java/java.editor/src/org/netbeans/modules/editor/java/Utilities.java:
##########
@@ -93,6 +94,7 @@
public final class Utilities {
private static final String ERROR = "<error>"; //NOI18N
+ private static final Pattern LINK_PATTERN = Pattern.compile("<a href='(\\*\\d+)'>(.*?)<\\/a>", Pattern.CASE_INSENSITIVE | Pattern.MULTILINE);
Review Comment:
Nitpick: `(.*?) -> (.*)` (* includes no repetition at all)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5963: VSCode: Various code completion enhancements.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5963:
URL: https://github.com/apache/netbeans/pull/5963#issuecomment-1553635117
this needs the https://github.com/apache/netbeans/labels/Java label since the changes are in java modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek commented on a diff in pull request #5963: VSCode: Various code completion enhancements.
Posted by "dbalek (via GitHub)" <gi...@apache.org>.
dbalek commented on code in PR #5963:
URL: https://github.com/apache/netbeans/pull/5963#discussion_r1199170924
##########
java/java.editor/src/org/netbeans/modules/editor/java/Utilities.java:
##########
@@ -93,6 +94,7 @@
public final class Utilities {
private static final String ERROR = "<error>"; //NOI18N
+ private static final Pattern LINK_PATTERN = Pattern.compile("<a href='(\\*\\d+)'>(.*?)<\\/a>", Pattern.CASE_INSENSITIVE | Pattern.MULTILINE);
Review Comment:
`.*` is a greedy quantifier that matches as many characters as possible while `.*?` is a lazy quantifier that matches as few characters as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] dbalek merged pull request #5963: VSCode: Various code completion enhancements.
Posted by "dbalek (via GitHub)" <gi...@apache.org>.
dbalek merged PR #5963:
URL: https://github.com/apache/netbeans/pull/5963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5963: VSCode: Various code completion enhancements.
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #5963:
URL: https://github.com/apache/netbeans/pull/5963#discussion_r1199418821
##########
java/java.editor/src/org/netbeans/modules/editor/java/Utilities.java:
##########
@@ -93,6 +94,7 @@
public final class Utilities {
private static final String ERROR = "<error>"; //NOI18N
+ private static final Pattern LINK_PATTERN = Pattern.compile("<a href='(\\*\\d+)'>(.*?)<\\/a>", Pattern.CASE_INSENSITIVE | Pattern.MULTILINE);
Review Comment:
eh, sorry ... forgot about greedy/lazy modifier. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists