[jira] Commented: (POOL-98) Make GenericObjectPool better extensible

["Hans Bausewein (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/POOL-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666192#action_12666192 ] 

Hans Bausewein commented on POOL-98:
------------------------------------

I was looking for MaxWait statistics. 

Tomcat exposes the configuration of a DBCP DataSource, which uses a GenericObjectPool internally, as an MBean.
( For a resource with name "jdbc/MyDS": Catalina:type=DataSource,path=/,host=localhost,class=javax.sql.DataSource,name="jdbc/MyDS" )

Here it is possible to specify a MaxWait time: i.e. the time to wait for a database connection to be returned to the pool.

For monitoring it is good to know, what the *actual* maximum wait time is: i.e. how close are we to the MaxWait limit?

MaxWait statistics also could provide useful for performance checks.


I would increase the priority of this issue.

> Make GenericObjectPool better extensible
> ----------------------------------------
>
>                 Key: POOL-98
>                 URL: https://issues.apache.org/jira/browse/POOL-98
>             Project: Commons Pool
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Henning Schmiedehausen
>            Priority: Minor
>             Fix For: 2.0
>
>
> The current implementation of GenericObjectPool encapsulates the _pool
> object and there is no way to get it directly, which makes some things
> like JMX pool monitoring a bit awkward.
> Would it be possible to either make _pool protected or add a method
> protected Collection getInternalPool() {
>         return _pool;
> }
> or something like that to the GenericObjectPool implementation (and
> probably others, but that is the one that bites me most... :-) )
> This would make extending the GenericObjectPool much easier.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.