svn commit: r1825395 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

[ma...@apache.org]

Author: markt
Date: Mon Feb 26 18:35:44 2018
New Revision: 1825395

URL: http://svn.apache.org/viewvc?rev=1825395&view=rev
Log:
Be a little more specific about exclusion patterns.

Modified:
    tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1825395&r1=1825394&r2=1825395&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Mon Feb 26 18:35:44 2018
@@ -282,7 +282,13 @@
   <Match>
     <!-- Field is only modified during Servlet load -->
     <Class name="org.apache.catalina.manager.host.HostManagerServlet" />
-    <Bug code="MSF" />
+    <Or>
+      <Field name="context" />
+      <Field name="installedHost" />
+      <Field name="engine" />
+      <Field name="wrapper" />
+    </Or>
+    <Bug pattern="MSF_MUTABLE_SERVLET_FIELD" />
   </Match>
   <Match>
     <!-- Catching exception is simpler than handling all the individual ones -->
@@ -293,6 +299,7 @@
   <Match>
     <!-- The fields are only set in setWrapper() which Tomcat calls once during
          initialisation. All other accesses are reads. -->
+    <Class name="org.apache.catalina.manager.ManagerServlet" />
     <Or>
       <Field name="context" />
       <Field name="host" />



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org