[GitHub] [doris] Gabriel39 commented on a diff in pull request #10311: [bug] fix window function nullable type bug

[GitBox <gi...@apache.org>]

Gabriel39 commented on code in PR #10311:
URL: https://github.com/apache/doris/pull/10311#discussion_r902483287


##########
be/src/vec/exec/vanalytic_eval_node.cpp:
##########
@@ -571,7 +571,16 @@ Status VAnalyticEvalNode::_output_current_block(Block* block) {
     }
 
     for (size_t i = 0; i < _result_window_columns.size(); ++i) {
-        block->insert({std::move(_result_window_columns[i]), _agg_functions[i]->data_type(), ""});
+        SlotDescriptor* output_slot_desc = _output_tuple_desc->slots()[i];

Review Comment:
   I think we should fix this bug in another way. Specifically, I think we should figure out why `_agg_functions[i]->data_type()` here is not nullable. Maybe we should change it to nullable in planning phase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org