You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2023/01/12 11:46:33 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #39532: [SPARK-42030][CORE] Remove unused Constructor from RocksDB.TypeAliases and LevelDB.TypeAliases
LuciferYang opened a new pull request, #39532:
URL: https://github.com/apache/spark/pull/39532
### What changes were proposed in this pull request?
This pr aims to remove unused Constructor from `RocksDB.TypeAliases` and `LevelDB.TypeAliases`.
### Why are the changes needed?
Code cleaning.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass Github Actions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang closed pull request #39532: [SPARK-42030][CORE] Remove unused Constructor from RocksDB.TypeAliases and LevelDB.TypeAliases
Posted by GitBox <gi...@apache.org>.
LuciferYang closed pull request #39532: [SPARK-42030][CORE] Remove unused Constructor from RocksDB.TypeAliases and LevelDB.TypeAliases
URL: https://github.com/apache/spark/pull/39532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #39532: [SPARK-42030][CORE] Remove unused Constructor from RocksDB.TypeAliases and LevelDB.TypeAliases
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on PR #39532:
URL: https://github.com/apache/spark/pull/39532#issuecomment-1381236764
close this one due to jackson need this Constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a diff in pull request #39532: [SPARK-42030][CORE] Remove unused Constructor from RocksDB.TypeAliases and LevelDB.TypeAliases
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on code in PR #39532:
URL: https://github.com/apache/spark/pull/39532#discussion_r1068029850
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDB.java:
##########
@@ -393,11 +393,6 @@ public static class TypeAliases {
TypeAliases(Map<String, byte[]> aliases) {
this.aliases = aliases;
}
-
- TypeAliases() {
- this(null);
Review Comment:
It is a useless constructor, I think we can delete it. If we need to keep it, it may be better to change it to init with a empty map
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org