[GitHub] [cassandra] dcapwell commented on a change in pull request #1454: CASSANDRA-17390 Expose streaming as a vtable

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #1454:
URL: https://github.com/apache/cassandra/pull/1454#discussion_r809536593



##########
File path: src/java/org/apache/cassandra/repair/LocalSyncTask.java
##########
@@ -93,7 +93,7 @@ StreamPlan createStreamPlan()
             plan.transferRanges(remote, desc.keyspace, RangesAtEndpoint.toDummyList(rangesToSync), desc.columnFamily);
         }
 
-        return plan;
+        return plan.withPlanId(desc.determanisticId());

Review comment:
       the idea is that streaming done by repair will use the RepairJob id (as defined by CASSANDRA-15399), so if a repair exists with the same planId, then this stream can map to the repair without any networking changes

##########
File path: src/java/org/apache/cassandra/repair/RepairJobDesc.java
##########
@@ -61,6 +68,17 @@ public RepairJobDesc(UUID parentSessionId, UUID sessionId, String keyspace, Stri
         this.ranges = ranges;
     }
 
+    public UUID determanisticId()

Review comment:
       the idea is that streaming done by repair will use the RepairJob id (as defined by CASSANDRA-15399), so if a repair exists with the same planId, then this stream can map to the repair without any networking changes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org