You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/10/12 22:36:48 UTC
[jira] Created: (MPECLIPSE-48) handling source attachments (patch)
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Versions:
1.9
Assignee:
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Tue, 12 Oct 2004 4:36 PM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: David Eric Pugh
Created: Fri, 15 Oct 2004 5:42 AM
Body:
fabrizio,
Since you are on a role, do you feel like seeing if some of this code:
+ <!-- check cactus sources -->
+ <j:set var="mappedsrc" value="cactus/${maven.eclipse.src.dir}/cactus-${depVersion}.${maven.eclipse.src.extension}"/>
+ <u:file var="checkSrcExist" name="${maven.repo.local}/${mappedsrc}" />
+ <j:choose>
+ <j:when test="${checkSrcExist.exists()}">
+ <classpathentry kind="var" path="MAVEN_REPO/cactus/jars/cactus-${depVersion}.jar" sourcepath="MAVEN_REPO/${mappedsrc}"/>
+ </j:when>
+ <j:otherwise>
+ <classpathentry kind="var" path="MAVEN_REPO/cactus/jars/cactus-${depVersion}.jar"/>
+ </j:otherwise>
+ </j:choose>
Can be converted into a tag? Something like <eclipse:checksource>? I can help you with this, but a good example is the artifact plugin. It seems like we are duplicating the same jelly over and over, and while it's good stuff, it makes it harder to read. I'll go ahead though and commit what you've already supplied.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=comments#action_25402
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Versions:
1.9
Assignee:
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Fri, 15 Oct 2004 5:42 AM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: fabrizio giustina (mailto:fgiust@gmail.com)
Date: Fri, 15 Oct 2004 4:26 AM
Comment:
updated again, also adding plugin tests for MPECLIPSE-47 and MPECLIPSE-49.
Note that actually paths for junit/cactus in test maven.xml have windows specific file separator "\" so probably tests will fail under Linux (this was already present before this patch).
Changes:
Attachment changed to MPECLIPSE-48.3_with_plugin_tests.diff
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Versions:
1.9
Assignee:
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Fri, 15 Oct 2004 4:26 AM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: David Eric Pugh
Created: Fri, 15 Oct 2004 5:48 AM
Body:
I ditched the property specifing the directory name "/src".. I don't think its needed, and I think our solution is only temporary. I reorganized the docs and added a section on the homepage about the linking of source directoires. Basically stating that "this implementation is for now until Maven properly deals with source artifacts".
Please review, as I had some changes conflicting with your changes, so I had to apply them.
Congrats on the unit tests! They caught at least one merge problem that I made. I appreciate these very clean patches.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=comments#action_25403
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Versions:
1.9
Assignee:
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Fri, 15 Oct 2004 5:48 AM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: David Eric Pugh
Created: Fri, 15 Oct 2004 11:23 AM
Body:
Did you pick up the changes that Emmanuel Venisse added?
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=comments#action_25433
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Versions:
1.9
Assignee:
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Fri, 15 Oct 2004 11:23 AM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: fabrizio giustina (mailto:fgiust@gmail.com)
Date: Tue, 12 Oct 2004 4:37 PM
Comment:
cvs diff (also includes an update to documentation)
Changes:
Attachment changed to MPECLIPSE-48.diff
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Versions:
1.9
Assignee:
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Tue, 12 Oct 2004 4:37 PM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: David Eric Pugh
Created: Tue, 19 Oct 2004 7:58 AM
Body:
I have applied and committed the patch. However, i think this introduced a bug.. the src/java directory is being added multiple times now...
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=comments#action_25557
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Versions:
1.9
Assignee:
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Tue, 19 Oct 2004 7:58 AM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: fabrizio giustina (mailto:fgiust@gmail.com)
Date: Thu, 14 Oct 2004 5:13 PM
Comment:
this is an updated version of the patch.
Updated after the MPECLIPSE-47 commit, fixes an error in the previous patch, and contains the fix for MPECLIPSE-49 too
Changes:
Attachment changed to MPECLIPSE-48_updated.diff
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Versions:
1.9
Assignee:
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Thu, 14 Oct 2004 5:13 PM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
Message:
The following issue has been closed.
Resolver: David Eric Pugh
Date: Wed, 20 Oct 2004 2:21 PM
Discussion on mailing list resolved my last concern.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Closed
Priority: Major
Resolution: FIXED
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Fix Fors:
1.9
Versions:
1.9
Assignee: David Eric Pugh
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Wed, 20 Oct 2004 2:21 PM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Andreas Schönknecht
Created: Fri, 22 Oct 2004 7:39 AM
Body:
Maven does contain some support for src.zip's already. When running the "dist" goals, a src.zip is built, named <artifactId>-<version>-src.zip.
This files is stored in the remote repository in a directory called "distributions". It would be nice if the Eclipse-Plugin would look there instead of the local repository, so I dont have to manually copy and rename them. Perhaps the "generate-classpath"-Goal could copy all needed src.zips from the remote repository distributions-directory to the local repository.
Before version 1.9 of Eclipse-Plug I worked as followed:
1. Edit the project.xml
2. Run eclipse:generate-classpath
3. Attach Sources manually in Eclipse via a Classpath variable that points to our remote-repository and expanding it to the src.zip in the distributions folder.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=comments#action_25682
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Closed
Priority: Major
Resolution: FIXED
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Fix Fors:
1.9
Versions:
1.9
Assignee: David Eric Pugh
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Fri, 22 Oct 2004 7:39 AM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: fabrizio giustina (mailto:fgiust@gmail.com)
Date: Fri, 15 Oct 2004 11:01 AM
Comment:
I should have done this from the beginning:
added an <eclipse:write-classpath-entry> tag which is used to resolve sources and to actually write down the classpath element to the file.
Also fixes the use of file.separator (in windows sometime \ and sometime /). I still couldn't find a way to use the ${file.separator} variable in x:set (in plugin tests), so tests will continue to fail on linux...
Please check the removal of dependency handle too: AFAIK this was already not needed since the pluginVar tag was already used. I replaced pluginVar with get and removed the dependency handle (not sure about this, the plugin should still work in maven < 1.0 ?)
Changes:
Attachment changed to MPECLIPSE-48.4_added_tag.diff
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Versions:
1.9
Assignee:
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Fri, 15 Oct 2004 11:01 AM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: fabrizio giustina (mailto:fgiust@gmail.com)
Date: Fri, 15 Oct 2004 11:19 AM
Comment:
ouch, emmanuel has been faster and clever than me in fixing the file separator issue...
so here it is the diff with the <eclipse:write-classpath-entry> tag merged with emmanuel fix
Changes:
Attachment changed to MPECLIPSE-48.5_tag_after_emmanuel_commit.diff
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Versions:
1.9
Assignee:
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Fri, 15 Oct 2004 11:19 AM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPECLIPSE-48) handling source attachments (patch)
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: David Eric Pugh
Created: Fri, 22 Oct 2004 8:50 AM
Body:
That is actually a good point about the src created by the dist goal. A patch would be appreciated. I was mostly interested in getting a barebones implementation in.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPECLIPSE-48?page=comments#action_25683
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPECLIPSE-48
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPECLIPSE-48
Summary: handling source attachments (patch)
Type: Improvement
Status: Closed
Priority: Major
Resolution: FIXED
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-eclipse-plugin
Fix Fors:
1.9
Versions:
1.9
Assignee: David Eric Pugh
Reporter: fabrizio giustina
Created: Tue, 12 Oct 2004 4:36 PM
Updated: Fri, 22 Oct 2004 8:50 AM
Description:
Actually maven repository doesn't contain source artifacts, however it would be nice if eclipse users could have a way to handle source for jars and have them added to eclipse .classpath (needed for debug and javadocs).
The attached path let users store sources in the local maven repository in the same way other artifacts are managed. Through the modification of the jar path the plugin will look for the sources file and, if existing, it will add them to the .classpath file.
The position of src files is controlled by 2 plugin properties: maven.eclipse.src.dir (directory for source artifact type) and maven.eclipse.src.extension (extension for files). These are temporarely managed as eclipse plugin properties till there is a standard maven default for them.
As an example, using the default values for these properties:
MAVEN_REPO/eclipse/jars/eclipse-ui-3.0.0.jar
will be mapped to
MAVEN_REPO/eclipse/src/eclipse-ui-3.0.0.zip
If the source zip is not available, it will not be added to the classpath file, so it will not cause any problem to users who don't have sources in their local repository.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org