[GitHub] [kyuubi] pan3793 commented on a diff in pull request #3933: [KYUUBI #3887] Provide kyuubiServerPrincipal as alias for principal in JDBC parameter

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #3933:
URL: https://github.com/apache/kyuubi/pull/3933#discussion_r1175396182


##########
kyuubi-hive-beeline/src/main/java/org/apache/hive/beeline/KyuubiCommands.java:
##########
@@ -459,28 +454,29 @@ public boolean connect(Properties props) throws IOException {
       }
     }
 
-    String auth = getProperty(props, new String[] {JdbcConnectionParams.AUTH_TYPE});
+    String auth = getProperty(props, new String[] {AUTH_TYPE});
     if (auth == null) {
       auth = beeLine.getOpts().getAuthType();
       if (auth != null) {
-        props.setProperty(JdbcConnectionParams.AUTH_TYPE, auth);
+        props.setProperty(AUTH_TYPE, auth);
       }
     }
 
     beeLine.info("Connecting to " + url);
-    if (Utils.parsePropertyFromUrl(url, JdbcConnectionParams.AUTH_PRINCIPAL) == null) {
+    if (Utils.parsePropertyFromUrl(url, AUTH_PRINCIPAL) == null
+        || Utils.parsePropertyFromUrl(url, AUTH_KYUUBI_SERVER_PRINCIPAL) == null) {

Review Comment:
   may be `&&`? @turboFei @lightning-L 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org