You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/30 07:22:55 UTC
[GitHub] [nifi] akatona84 commented on a change in pull request #4950: NIFI-8380: Allow for an extensions.directory property to specify wher…
akatona84 commented on a change in pull request #4950:
URL: https://github.com/apache/nifi/pull/4950#discussion_r603839628
##########
File path: nifi-external/nifi-kafka-connect/nifi-kafka-connector/src/main/java/org/apache/nifi/kafka/connect/validators/ConnectDirectoryExistsValidator.java
##########
@@ -34,7 +34,7 @@ public void ensureValid(final String name, final Object value) {
}
final File file = new File((String) value);
- if (!file.exists()) {
+ if (!file.exists() && !file.mkdirs()) {
Review comment:
Is this necessary to create the dir in the validation phase?
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/flow/StatelessDataflow.java
##########
@@ -24,8 +24,33 @@
import java.util.Set;
public interface StatelessDataflow {
Review comment:
It is not part of this PR, but wouldn't make sense to make it extend AutoClosable? and having close() instead of shutdown(), etc.
##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-stateless-bundle/nifi-stateless-api/src/main/java/org/apache/nifi/stateless/flow/StatelessDataflow.java
##########
@@ -24,8 +24,33 @@
import java.util.Set;
public interface StatelessDataflow {
Review comment:
It is not part of this PR, but wouldn't make sense to make it extend AutoClosable? and having close() instead of shutdown(), etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org