You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Sharmarke Aden (JIRA)" <ji...@apache.org> on 2012/11/30 10:05:58 UTC

[jira] [Created] (AVRO-1213) Dependency on Jetty Servlet API in IPC

Sharmarke Aden created AVRO-1213:
------------------------------------

             Summary: Dependency on Jetty Servlet API in IPC
                 Key: AVRO-1213
                 URL: https://issues.apache.org/jira/browse/AVRO-1213
             Project: Avro
          Issue Type: Improvement
          Components: java
    Affects Versions: 1.7.2
            Reporter: Sharmarke Aden
            Priority: Minor


The compile scoped dependency on jetty servlet-api in the IPC pom file can be problematic if using Avro in a webapp environment. Would it be possible to make this dependency either optional or provided? Or maybe Avro modularize into sub-modules in such a way that desired features can be assembled piecemeal?



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AVRO-1213) Dependency on Jetty Servlet API in IPC

Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507478#comment-13507478 ] 

Doug Cutting commented on AVRO-1213:
------------------------------------

Optional sounds reasonable to me.  It's hard to use a servlet without having that provided and we shouldn't mandate a particular source for the servlet api.

And shouldn't the other Jetty dependencies be for tests only?
                
> Dependency on Jetty Servlet API in IPC
> --------------------------------------
>
>                 Key: AVRO-1213
>                 URL: https://issues.apache.org/jira/browse/AVRO-1213
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.2
>            Reporter: Sharmarke Aden
>            Priority: Minor
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be problematic if using Avro in a webapp environment. Would it be possible to make this dependency either optional or provided? Or maybe Avro modularize into sub-modules in such a way that desired features can be assembled piecemeal?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AVRO-1213) Dependency on Jetty Servlet API in IPC

Posted by "Scott Carey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507574#comment-13507574 ] 

Scott Carey commented on AVRO-1213:
-----------------------------------

Optional is OK for now for Jetty, and Netty.  The use can choose which they want.  Optional may require changing avro-tools' pom to declare those, and we'll need to document the change.  I'd say it would need to wait until 1.8.0 because upgrading would break current projects, and there is a work-around for users now to exclude jetty and/or the servlet downstream dependencies in their pom.

Longer term, we could break up IPC into more modules, one for HTTP RPC and another for socket, since the two have very different downstream dependencies.
                
> Dependency on Jetty Servlet API in IPC
> --------------------------------------
>
>                 Key: AVRO-1213
>                 URL: https://issues.apache.org/jira/browse/AVRO-1213
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.2
>            Reporter: Sharmarke Aden
>            Priority: Minor
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be problematic if using Avro in a webapp environment. Would it be possible to make this dependency either optional or provided? Or maybe Avro modularize into sub-modules in such a way that desired features can be assembled piecemeal?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (AVRO-1213) Dependency on Jetty Servlet API in IPC

Posted by "Sharmarke Aden (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AVRO-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507712#comment-13507712 ] 

Sharmarke Aden commented on AVRO-1213:
--------------------------------------

Doug,

I wasn't really sure in what capacity Jetty is used but looking at IPC code it looks like those jetty dependencies are needed down stream by those wishing to use IPC. 


Scott, 

I think you are right on them money. Ultimately what you want to do is break the IPC into Jetty and Netty sub-modules so they can become optional and allow of future growth with respect to adding new Server implementations (i.e. tomcat, vert.x, NodeJS, etc).
                
> Dependency on Jetty Servlet API in IPC
> --------------------------------------
>
>                 Key: AVRO-1213
>                 URL: https://issues.apache.org/jira/browse/AVRO-1213
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>    Affects Versions: 1.7.2
>            Reporter: Sharmarke Aden
>            Priority: Minor
>
> The compile scoped dependency on jetty servlet-api in the IPC pom file can be problematic if using Avro in a webapp environment. Would it be possible to make this dependency either optional or provided? Or maybe Avro modularize into sub-modules in such a way that desired features can be assembled piecemeal?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira