You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 18:53:49 UTC
[GitHub] [arrow-nanoarrow] paleolimbot opened a new issue, #7: Fix memcheck
paleolimbot opened a new issue, #7:
URL: https://github.com/apache/arrow-nanoarrow/issues/7
Right now the valgrind test isn't actually testing for memory leaks...we actually just need to:
- Add `include(CTest)` in CMakeLists.txt if building tests
- Change the current command to `ctest -T memcheck` in .github/workflows
- Check for non-empty files matching build/Testing/Temporary/MemoryChecker* (then upload as artifact)
- Figure out how to exclude the "possible leak" coming from jemalloc:
```
==496952== 368 bytes in 1 blocks are possibly lost in loss record 1 of 1
==496952== at 0x483DD99: calloc (in /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.so)
==496952== by 0x40149DA: allocate_dtv (dl-tls.c:286)
==496952== by 0x40149DA: _dl_allocate_tls (dl-tls.c:532)
==496952== by 0x771B322: allocate_stack (allocatestack.c:622)
==496952== by 0x771B322: pthread_create@@GLIBC_2.2.5 (pthread_create.c:660)
==496952== by 0x62C7ACB: je_arrow_private_je_pthread_create_wrapper (background_thread.c:47)
==496952== by 0x62C7ACB: background_thread_create_signals_masked (background_thread.c:287)
==496952== by 0x62C7ACB: background_thread_create_locked (background_thread.c:495)
==496952== by 0x62C7CBB: je_arrow_private_je_background_thread_create (background_thread.c:520)
==496952== by 0x62B2668: malloc_init_hard (jemalloc.c:2176)
==496952== by 0x62B2668: malloc_init_hard (jemalloc.c:2112)
==496952== by 0x4011B99: call_init.part.0 (dl-init.c:72)
==496952== by 0x4011CA0: call_init (dl-init.c:30)
==496952== by 0x4011CA0: _dl_init (dl-init.c:119)
==496952== by 0x4001139: ??? (in /usr/lib/x86_64-linux-gnu/ld-2.31.so)
==496952== by 0x2: ???
==496952== by 0x1FFF00038E: ???
==496952== by 0x1FFF0003C0: ???
==496952== by 0x1FFF0003E5: ???
==496952==
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] lidavidm commented on issue #7: Fix memcheck
Posted by GitBox <gi...@apache.org>.
lidavidm commented on issue #7:
URL: https://github.com/apache/arrow-nanoarrow/issues/7#issuecomment-1195873419
FWIW: Arrow does this sort of thing here https://github.com/apache/arrow/blob/master/cpp/valgrind.supp
Can't claim to understand how it works, but it gets set up here: https://github.com/apache/arrow/blob/9c93f82a06ecae4d0e51f64b25fc63d32701d734/cpp/cmake_modules/BuildUtils.cmake#L698-L715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot closed issue #7: Fix memcheck
Posted by GitBox <gi...@apache.org>.
paleolimbot closed issue #7: Fix memcheck
URL: https://github.com/apache/arrow-nanoarrow/issues/7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org