You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2016/08/03 01:55:21 UTC
[jira] [Updated] (SOLR-9314) Add all known transformers to
TestRandomFlRTGCloud and fix any bugs found
[ https://issues.apache.org/jira/browse/SOLR-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-9314:
---------------------------
Attachment: SOLR-9314.patch
Updated patch to include a "testCoverage" that compares what validators we have with {{TransformerFactory.defaultFactories}} and a new RawFieldValueValidator for testing the {{\[json\]}} and {{\[xml\]}} transformers (backed by RawValueTransformerFactory)
There's currently test failures related to RawFieldValueValidator -- i haven't dug in in depth, but it doesn't look like a test bug, it might be an actual bug in RawValueTransformerFactory when dealing with uncommited docs -- need to do some manual testing to sanity check. (I skimmed teh code in RawValueTransformerFactory but nothing jumped out at me)
> Add all known transformers to TestRandomFlRTGCloud and fix any bugs found
> -------------------------------------------------------------------------
>
> Key: SOLR-9314
> URL: https://issues.apache.org/jira/browse/SOLR-9314
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Hoss Man
> Attachments: SOLR-9314.patch, SOLR-9314.patch
>
>
> SOLR-9285 is/has added a new TestRandomFlRTGCloud for testing out random permutations of {{fl}} params in RTG requests.
> simple field names, field renames, field globs, and ValueSources/functions are already tested -- adding additional DocTransformers is fairly straight forward by implementing a simple FlValidator.
> This issue is being filed to track the work needed to:
> * review the list of all DocTransformers in solr and add test coverage of them in this method
> * file any blocker issues if new bugs are found in this process
> * once all DocTransformers are accounted for, update TestRandomFlRTGCloud to programatically compare the list of FlValidator's it knows about with the list of all DocTransformers (similar to how QueryEqualityTest.testParserCoverage works) to fail the test if anyone adds a DocTransformer w/o adding corisponding test coverage to this class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org