You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/06/01 06:43:00 UTC
[jira] [Work logged] (LANG-1547) fix code smells; fix typos;
performance refine(trying to)
[ https://issues.apache.org/jira/browse/LANG-1547?focusedWorklogId=439360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-439360 ]
ASF GitHub Bot logged work on LANG-1547:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jun/20 06:42
Start Date: 01/Jun/20 06:42
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #533:
URL: https://github.com/apache/commons-lang/pull/533#issuecomment-636643768
> I'd find it reasonable to consider your changes in batches of, say, ten apiece. (That would make it possible to carefully inspect one by one.) But that many in one go? Definitely no.
@XenoAmess it's quite hard to review this PR. It has several commits, and several changes. Committers will have to read and understand your changes, and then be confident that these changes can go in the next release without causing regressions.
As @jochenw pointed out, instead if you could prepare one pull request for a change, and either include your other changes in another PR, or wait for a review/merge to submit more, that would be much easier to review; at the same time, your PR would be reviewed much faster.
Bruno
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 439360)
Time Spent: 1h 50m (was: 1h 40m)
> fix code smells; fix typos; performance refine(trying to)
> ---------------------------------------------------------
>
> Key: LANG-1547
> URL: https://issues.apache.org/jira/browse/LANG-1547
> Project: Commons Lang
> Issue Type: Improvement
> Reporter: JIN XU
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> [https://github.com/apache/commons-lang/pull/533]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)