You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "craigcondit (via GitHub)" <gi...@apache.org> on 2023/06/20 14:34:29 UTC
[GitHub] [yunikorn-core] craigcondit opened a new pull request, #575: [YUNIKORN-1827] Add core.application.usage logger
craigcondit opened a new pull request, #575:
URL: https://github.com/apache/yunikorn-core/pull/575
Log the messages added by YUNIKORN-1385 (application aggregated resource tracking) so that they may be selectively enabled/disabled.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [x] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1827
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #575: [YUNIKORN-1827] Add core.application.usage logger
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #575:
URL: https://github.com/apache/yunikorn-core/pull/575#issuecomment-1598925912
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#575](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ae58523) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/a6a90bb0408a3004592f06d8a79335ac326dcfe4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a6a90bb) will **increase** coverage by `0.12%`.
> The diff coverage is `84.33%`.
```diff
@@ Coverage Diff @@
## master #575 +/- ##
==========================================
+ Coverage 75.45% 75.58% +0.12%
==========================================
Files 73 74 +1
Lines 12057 12137 +80
==========================================
+ Hits 9098 9174 +76
- Misses 2638 2642 +4
Partials 321 321
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg/log/filtered\_core.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2xvZy9maWx0ZXJlZF9jb3JlLmdv) | `43.75% <43.75%> (ø)` | |
| [pkg/webservice/handlers.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `80.26% <66.66%> (+0.46%)` | :arrow_up: |
| [pkg/log/logger.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | `88.96% <85.96%> (+9.47%)` | :arrow_up: |
| [pkg/common/configs/configs.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3MuZ28=) | `85.18% <100.00%> (+1.51%)` | :arrow_up: |
| [pkg/scheduler/objects/application.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL2FwcGxpY2F0aW9uLmdv) | `65.41% <100.00%> (ø)` | |
| [pkg/scheduler/objects/node.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `82.60% <100.00%> (+0.04%)` | :arrow_up: |
| [pkg/scheduler/placement/filter.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvZmlsdGVyLmdv) | `89.83% <100.00%> (+0.08%)` | :arrow_up: |
| [pkg/scheduler/placement/placement.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3NjaGVkdWxlci9wbGFjZW1lbnQvcGxhY2VtZW50Lmdv) | `83.21% <100.00%> (-0.13%)` | :arrow_down: |
| [pkg/webservice/state\_dump.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/575?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGtnL3dlYnNlcnZpY2Uvc3RhdGVfZHVtcC5nbw==) | `70.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #575: [YUNIKORN-1827] Add core.application.usage logger
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #575: [YUNIKORN-1827] Add core.application.usage logger
URL: https://github.com/apache/yunikorn-core/pull/575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org