[GitHub] [helix] jiajunwang commented on a change in pull request #1846: Fix management mode history duplicate recording

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1846:
URL: https://github.com/apache/helix/pull/1846#discussion_r694320173



##########
File path: helix-core/src/main/java/org/apache/helix/controller/stages/ManagementModeStage.java
##########
@@ -157,14 +163,14 @@ private void recordClusterStatus(ClusterManagementMode mode, HelixDataAccessor a
       return;

Review comment:
       If it is a new state record, but it is fully frozen, we don't record the history? I guess this is not what we want.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org