[jira] [Commented] (LOG4PHP-130) LoggerAppenderFile creates empty log files

["Juraj Zitniak (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4PHP-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400434#comment-13400434 ] 

Juraj Zitniak commented on LOG4PHP-130:
---------------------------------------

Hello,

we also need it in our project. We have many users visiting our site and each request opens empty file which it's time consuming and it slows our site. Currently we must modify sources of log4php so we could use it. Please could you implement this issue ?

Thank you

Juraj
                
> LoggerAppenderFile creates empty log files
> ------------------------------------------
>
>                 Key: LOG4PHP-130
>                 URL: https://issues.apache.org/jira/browse/LOG4PHP-130
>             Project: Log4php
>          Issue Type: Bug
>          Components: Code
>    Affects Versions: 2.0.0
>         Environment: -
>            Reporter: igor nadj
>            Priority: Minor
>
> My configuration uses LoggerAppenderDailyFile with a date pattern which includes seconds, the intent is to create a new log file for each error. The issue I've come across is that at each request it opens the file, then closes it (writing out the footer) without actually logging any error messages. My solution is to move the file-creation code to the time when the first log event is handled.
> My pseudo-patch submission: 
> In LoggerAppenderFile.php
> Change 
> public function activateOptions(){ ... }
> to a stub
> public function activateOptions(){ }
> moving the contents of activateOptions to a new function
> protected function open(){
>  if($this->fp) return;
>  <code from activateOptions here>
> }
> where the new function is called at the start of append()
> public function append(LoggerLoggingEvent $event) {
>  if(!$this->fp) $this->open();
>  <rest of function>
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira