You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Joe Stein <cr...@gmail.com> on 2014/09/24 16:10:59 UTC
Review Request 25992: Patch for KAFKA-1645
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25992/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1645
https://issues.apache.org/jira/browse/KAFKA-1645
Repository: kafka
Description
-------
KAFKA-1645 remove jars from repository so they aren't in our src release
Diffs
-----
build.gradle 63e20651e3b6d679f47d2b60b573f4532a5dd720
contrib/hadoop-consumer/lib/piggybank.jar cbd46e065aab036a6159e029b9294c4d17d9c2ff
contrib/hadoop-producer/lib/piggybank.jar cbd46e065aab036a6159e029b9294c4d17d9c2ff
lib/apache-rat-0.8.jar bdc43726d636947c33f215550a98ec44bb0ce0be
system_test/migration_tool_testsuite/0.7/bin/kafka-run-class.sh ec92a343ebfeecb21a1bf67b5eacb6891c9971c9
system_test/migration_tool_testsuite/0.7/bin/zookeeper-server-start.sh 184a10be05f586ec0114c6f23f0633aa1d96cfa7
system_test/migration_tool_testsuite/0.7/config/log4j.properties baa698b64259b18efed372cf009a04613b6c53cf
system_test/migration_tool_testsuite/0.7/config/test-log4j.properties a3ae33f20e4b7cff87d8cf8368d0639b8bea73a6
system_test/migration_tool_testsuite/0.7/lib/kafka-0.7.0.jar 982ddb953aaa1167952beeb0b01db074c7c8550f
system_test/migration_tool_testsuite/0.7/lib/kafka-perf-0.7.0.jar d4f89d54907affea7186c5f4d28e9f5fe7069466
system_test/migration_tool_testsuite/0.7/lib/zkclient-0.1.jar aebcc3491adb3b3928673d78fb3878facd5cc0c3
system_test/migration_tool_testsuite/__init__.py 8d1c8b69c3fce7bea45c73efd06983e3c419a92f
system_test/migration_tool_testsuite/cluster_config.json cd7f079455fdd92f58335a5a8839843fde850b4b
system_test/migration_tool_testsuite/config/migration_consumer.properties 184f1dea16475d8d6018f7f0a68f5e7a71d35b2d
system_test/migration_tool_testsuite/config/migration_producer.properties 7a2265a3e347a47521b7988888dd53e55fbc0ff3
system_test/migration_tool_testsuite/config/server.properties 54144a28a08000ecc2aa3f3d540908669f2c4ebc
system_test/migration_tool_testsuite/config/zookeeper.properties 74cbf90428f817c44f9fa64e9d91caf06e7a1067
system_test/migration_tool_testsuite/migration_tool_test.py 95948353d1e73936122035f4d50e07965871a3e1
system_test/migration_tool_testsuite/testcase_9001/testcase_9001_properties.json 608e3bdf79cc40114d94beaba09e27593ad5a834
system_test/migration_tool_testsuite/testcase_9003/cluster_config.json 766a001030f69c4df5e4b1e17e47fc767a2778d7
system_test/migration_tool_testsuite/testcase_9003/testcase_9003_properties.json 333256c8f53a6850a4a267fcf4cbe65394d9fb96
system_test/migration_tool_testsuite/testcase_9004/cluster_config.json 766a001030f69c4df5e4b1e17e47fc767a2778d7
system_test/migration_tool_testsuite/testcase_9004/testcase_9004_properties.json b2a6e85e575b404faaa1a2019857c13c491e5eea
system_test/migration_tool_testsuite/testcase_9005/cluster_config.json 9fcb3b0400bd8ff9f6710f953f1ae484f49252bc
system_test/migration_tool_testsuite/testcase_9005/testcase_9005_properties.json ddbc90506902c6c0c67348ab70ee6bb9df33cb98
system_test/migration_tool_testsuite/testcase_9006/cluster_config.json 9fcb3b0400bd8ff9f6710f953f1ae484f49252bc
system_test/migration_tool_testsuite/testcase_9006/testcase_9006_properties.json 21b4c40e207acf39d0dc1a4c0ec790f8a22b71e6
Diff: https://reviews.apache.org/r/25992/diff/
Testing
-------
Thanks,
Joe Stein
Re: Review Request 25992: Patch for KAFKA-1645
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25992/#review54508
-----------------------------------------------------------
Ship it!
Could you also remove the migration test cases in system_test/testcase_to_run_all.json?
build.gradle
<https://reviews.apache.org/r/25992/#comment94690>
build.gradle
<https://reviews.apache.org/r/25992/#comment94691>
This is not needed.
build.gradle
<https://reviews.apache.org/r/25992/#comment94692>
There is a compilation error when building the jar. Need to change this line to the following.
compile("org.apache.avro:avro:1.4.0") { force = true }
- Jun Rao
On Sept. 24, 2014, 2:10 p.m., Joe Stein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25992/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 2:10 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1645
> https://issues.apache.org/jira/browse/KAFKA-1645
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1645 remove jars from repository so they aren't in our src release
>
>
> Diffs
> -----
>
> build.gradle 63e20651e3b6d679f47d2b60b573f4532a5dd720
> contrib/hadoop-consumer/lib/piggybank.jar cbd46e065aab036a6159e029b9294c4d17d9c2ff
> contrib/hadoop-producer/lib/piggybank.jar cbd46e065aab036a6159e029b9294c4d17d9c2ff
> lib/apache-rat-0.8.jar bdc43726d636947c33f215550a98ec44bb0ce0be
> system_test/migration_tool_testsuite/0.7/bin/kafka-run-class.sh ec92a343ebfeecb21a1bf67b5eacb6891c9971c9
> system_test/migration_tool_testsuite/0.7/bin/zookeeper-server-start.sh 184a10be05f586ec0114c6f23f0633aa1d96cfa7
> system_test/migration_tool_testsuite/0.7/config/log4j.properties baa698b64259b18efed372cf009a04613b6c53cf
> system_test/migration_tool_testsuite/0.7/config/test-log4j.properties a3ae33f20e4b7cff87d8cf8368d0639b8bea73a6
> system_test/migration_tool_testsuite/0.7/lib/kafka-0.7.0.jar 982ddb953aaa1167952beeb0b01db074c7c8550f
> system_test/migration_tool_testsuite/0.7/lib/kafka-perf-0.7.0.jar d4f89d54907affea7186c5f4d28e9f5fe7069466
> system_test/migration_tool_testsuite/0.7/lib/zkclient-0.1.jar aebcc3491adb3b3928673d78fb3878facd5cc0c3
> system_test/migration_tool_testsuite/__init__.py 8d1c8b69c3fce7bea45c73efd06983e3c419a92f
> system_test/migration_tool_testsuite/cluster_config.json cd7f079455fdd92f58335a5a8839843fde850b4b
> system_test/migration_tool_testsuite/config/migration_consumer.properties 184f1dea16475d8d6018f7f0a68f5e7a71d35b2d
> system_test/migration_tool_testsuite/config/migration_producer.properties 7a2265a3e347a47521b7988888dd53e55fbc0ff3
> system_test/migration_tool_testsuite/config/server.properties 54144a28a08000ecc2aa3f3d540908669f2c4ebc
> system_test/migration_tool_testsuite/config/zookeeper.properties 74cbf90428f817c44f9fa64e9d91caf06e7a1067
> system_test/migration_tool_testsuite/migration_tool_test.py 95948353d1e73936122035f4d50e07965871a3e1
> system_test/migration_tool_testsuite/testcase_9001/testcase_9001_properties.json 608e3bdf79cc40114d94beaba09e27593ad5a834
> system_test/migration_tool_testsuite/testcase_9003/cluster_config.json 766a001030f69c4df5e4b1e17e47fc767a2778d7
> system_test/migration_tool_testsuite/testcase_9003/testcase_9003_properties.json 333256c8f53a6850a4a267fcf4cbe65394d9fb96
> system_test/migration_tool_testsuite/testcase_9004/cluster_config.json 766a001030f69c4df5e4b1e17e47fc767a2778d7
> system_test/migration_tool_testsuite/testcase_9004/testcase_9004_properties.json b2a6e85e575b404faaa1a2019857c13c491e5eea
> system_test/migration_tool_testsuite/testcase_9005/cluster_config.json 9fcb3b0400bd8ff9f6710f953f1ae484f49252bc
> system_test/migration_tool_testsuite/testcase_9005/testcase_9005_properties.json ddbc90506902c6c0c67348ab70ee6bb9df33cb98
> system_test/migration_tool_testsuite/testcase_9006/cluster_config.json 9fcb3b0400bd8ff9f6710f953f1ae484f49252bc
> system_test/migration_tool_testsuite/testcase_9006/testcase_9006_properties.json 21b4c40e207acf39d0dc1a4c0ec790f8a22b71e6
>
> Diff: https://reviews.apache.org/r/25992/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joe Stein
>
>