You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/13 09:04:28 UTC
[GitHub] [airflow] ashb opened a new pull request #11491: Enable serialization by default
ashb opened a new pull request #11491:
URL: https://github.com/apache/airflow/pull/11491
We actually need to make serialization the default, but this is an
interim measure for Airflow2.0.0.alpha1 reease
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11491: Enable serialization by default
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11491:
URL: https://github.com/apache/airflow/pull/11491#discussion_r503869171
##########
File path: airflow/config_templates/default_test.cfg
##########
@@ -45,6 +45,8 @@ killed_task_cleanup_time = 5
hostname_callable = socket.getfqdn
worker_precheck = False
default_task_retries = 0
+# This is a hack, too many tests assume DAGs are already in the DB. We need to fix those tests instead
+store_serialized_dags = False
Review comment:
This will be taken care of by https://github.com/apache/airflow/pull/11335
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11491: Enable serialization by default
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11491:
URL: https://github.com/apache/airflow/pull/11491#issuecomment-707688007
Should we add an entry in UPATING.md?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #11491: Enable serialization by default
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11491:
URL: https://github.com/apache/airflow/pull/11491#discussion_r503869171
##########
File path: airflow/config_templates/default_test.cfg
##########
@@ -45,6 +45,8 @@ killed_task_cleanup_time = 5
hostname_callable = socket.getfqdn
worker_precheck = False
default_task_retries = 0
+# This is a hack, too many tests assume DAGs are already in the DB. We need to fix those tests instead
+store_serialized_dags = False
Review comment:
This will be taken care of in https://github.com/apache/airflow/pull/11335
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11491: Enable serialization by default
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11491:
URL: https://github.com/apache/airflow/pull/11491#issuecomment-707689820
> Should we add an entry in UPATING.md?
Done here: https://github.com/apache/airflow/pull/11335 (still a WIP though)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #11491: Enable serialization by default
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #11491:
URL: https://github.com/apache/airflow/pull/11491
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org