You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "David Li (Jira)" <ji...@apache.org> on 2020/03/18 20:56:00 UTC

[jira] [Commented] (ARROW-7966) [Integration][Flight][C++] Client should verify each batch independently

    [ https://issues.apache.org/jira/browse/ARROW-7966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17062043#comment-17062043 ] 

David Li commented on ARROW-7966:
---------------------------------

Fixing this causes the test I added in ARROW-7899 to fail again. I'll dig deeper...

> [Integration][Flight][C++] Client should verify each batch independently
> ------------------------------------------------------------------------
>
>                 Key: ARROW-7966
>                 URL: https://issues.apache.org/jira/browse/ARROW-7966
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++, FlightRPC, Integration
>            Reporter: Bryan Cutler
>            Assignee: David Li
>            Priority: Major
>
> Currently the C++ Flight test client in {{test_integration_client.cc}} reads all batches from JSON into a Table, reads all batches in the flight stream from the server into a Table, then compares the Tables for equality.  This is potentially a problem because a record batch might have specific information that is then lost in the conversion to a Table. For example, if the server sends empty batches, the resulting Table would not be different from one with no empty batches.
> Instead, the client should check each record batch from the JSON file against each record batch from the server independently. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)