You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/05 11:28:51 UTC

[GitHub] [nuttx] wengzhe opened a new pull request, #8029: net: downgrade iob priority of input/udp/icmp to avoid blocking devif

wengzhe opened a new pull request, #8029:
URL: https://github.com/apache/nuttx/pull/8029

   ## Summary
   When trying to use iperf2, we found it comsumes all the IOB when sending UDP packets, then devif_poll has no IOB to send the packet out, so speed drops to 0 and never recovers.
   
   ## Impact
   Change the `throttled` param of some protocols.
   
   ## Testing
   Tested with vela internal tools.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #8029: net: downgrade iob priority of input/udp/icmp to avoid blocking devif

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8029:
URL: https://github.com/apache/nuttx/pull/8029


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8029: net: downgrade iob priority of input/udp/icmp to avoid blocking devif

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #8029:
URL: https://github.com/apache/nuttx/pull/8029#discussion_r1062557325


##########
net/netdev/netdev_iob.c:
##########
@@ -60,10 +60,10 @@ int netdev_iob_prepare(FAR struct net_driver_s *dev, bool throttled,
 
   if (dev->d_iob == NULL)
     {
-      dev->d_iob = net_iobtimedalloc(false, timeout);
-      if (dev->d_iob == NULL && throttled)
+      dev->d_iob = net_iobtimedalloc(true, timeout);
+      if (dev->d_iob == NULL && throttled == false)

Review Comment:
   `!throttled`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org