You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Disha Talreja via Review Board <no...@reviews.apache.org> on 2022/09/14 02:29:41 UTC
Review Request 74117: ATLAS-4674 : Regression: Classification tagging is not sending appropriate notification to ATLAS_ENTITIES
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74117/
-----------------------------------------------------------
Review request for atlas, Radhika Kundam and Sidharth Mishra.
Bugs: ATLAS-4674
https://issues.apache.org/jira/browse/ATLAS-4674
Repository: atlas
Description
-------
When we add/delete a classification from an entity, we send notification to ATLAS_ENTITIES so ranger tag sync works appropriately to facilitate Tag-based policy. This functionally seems to be broken and is a regression.
On further investigation, it is seen that the issue is caused by deferred action for classification propagation as the right notifications are sent when deferred action is disabled.
Entity details for the notification messages are fetched from the entity cache which is not updated and lacks the new classification mapping. Hence, this patch clears the cache so that the entity is newly mapped from it's vertex and contains all the information.
Diffs
-----
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java 68d331dfd
Diff: https://reviews.apache.org/r/74117/diff/1/
Testing
-------
mvn clean -DskipTests install
mvn clean -DskipTests package -Pdist,embedded-hbase-solr
Atlas server running.
Classification add, Classification delete: Verified appropriate messages being received on ATLAS_ENTITIES.
Thanks,
Disha Talreja