You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@sentry.apache.org by "kalyan kumar kalvagadda (JIRA)" <ji...@apache.org> on 2017/05/30 21:52:04 UTC
[jira] [Comment Edited] (SENTRY-1773) Delta change cleaner should
leave way more then a single entry intact
[ https://issues.apache.org/jira/browse/SENTRY-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030195#comment-16030195 ]
kalyan kumar kalvagadda edited comment on SENTRY-1773 at 5/30/17 9:51 PM:
--------------------------------------------------------------------------
[~akolb]
When we need cleanup data, there needs to be some criteria to decides which data stays and which should be deleted. Here are some of the ways to cleanup.
# Always leave last "X" entries in the delta tables. This was the approach taken currently. Currently X=1.
** This approach has issues as we can't be really sure if data that is cleaned up is ever served to NN.
# Determine what can be cleanup based on update requests coming from NN.
** Server should just maintain snapshots and deltas, but it should also keep track of the last change-id that NN successfully processed. That way, sentry server knows what to cleanup and what stays.
was (Author: kkalyan):
[~akolb]
When we need cleanup data, there needs to be some criteria to decides which data stays and which should be deleted. Here are some of the ways to cleanup.
# Always leave last "X" entries in the delta tables. This was the approach taken currently. Currently X=1.
** This approach has issues as we can't be really sure if data that is cleaned up is ever served to NN.
# Determine what can be cleanup based on update requests coming from NN.
** Server should just maintain snapshots and deltas, but it should also keep track of the last change-id that NN successfully processed. That way sentry server knows what to cleanup and what stays.
> Delta change cleaner should leave way more then a single entry intact
> ---------------------------------------------------------------------
>
> Key: SENTRY-1773
> URL: https://issues.apache.org/jira/browse/SENTRY-1773
> Project: Sentry
> Issue Type: Sub-task
> Components: Sentry
> Affects Versions: sentry-ha-redesign
> Reporter: Alexander Kolbasov
> Assignee: kalyan kumar kalvagadda
> Fix For: sentry-ha-redesign
>
>
> The delta cleaner removes deltas thus causing NN full update unnecessary.
> I think it should keep more then 1 delta.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)