[GitHub] [activemq-artemis] gtully commented on pull request #3676: ARTEMIS-1925 - allow redistribution with loadbalance type of OFF to e…

[GitBox <gi...@apache.org>]

gtully commented on pull request #3676:
URL: https://github.com/apache/activemq-artemis/pull/3676#issuecomment-888154546


   > e.g. im using OFF to ensure redistribute never occurs, regardless. it should never redistribute.
   in my reading of the code and doc, this is just a broken assumption.
   disable redistribution by not enabling redistribution.
   
   redistribution is a solution to the problem of stuck messages due to early load balancing at routing time.
   what is nice is that it is separate and it can have a binary behaviour.
   5.x has deceaseNetworkConsumerPriority that biases towards local consumers. enabling redistribution can make such a feature binary (and better) when combined with no loadbalancing on initial routing. 
   
   ON_DEMAND is like STRICT when there are remote consumers, if we only want to go remote when we have stuck messages, then redistribution is the nice answer.
   this change makes that possible by extending what is there in a natural way.
   
   the change in semantic, that needs to be communicated for sure, but it need not be a blocker.
   the real semantics are in the code and test and git history, all the tests are fine with this change and the new test verifies it.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org