[GitHub] [activemq-artemis] Havret edited a comment on pull request #3124: [WIP] ARTEMIS-2614 Create queues based on FQQN - AMQP

[GitBox <gi...@apache.org>]

Havret edited a comment on pull request #3124:
URL: https://github.com/apache/activemq-artemis/pull/3124#issuecomment-633233631


   @jbertram, @gemmellr 
   
   So after all it wasn't too productive discussion. I debugged the code, and apparently methods `createSharedDurableQueue` and `createUnsharedDurableQueue` don't explicitly create durable queues. The queues are durable by default if it's not specified otherwise. So if I drop "setDurable" bits, FQQN queues will be created as durable which makes sense, and doesn't break anything.
   
   However, there are still some things that need to be cleared up regarding my first question. 
   
   > There is a problem with the RoutingType mismatch. Previously it didn't matter what RoutingType receiver tries to attach to, as the implementation assumed pre-existence of the queue. Now the routing type matters, as we need to create a properly configured queue if it doesn't exist. That's why testQueueConsumerReceiveTopicUsingFQQN test fails currently. To make it pass I would need to subscribe to a topic instead of a queue. I'm not sure but is this a breaking change or not?
   
   STOMP implementation that @jbertram recently added https://github.com/apache/activemq-artemis/pull/3018 seems to silently ignore passed routing type when the mismatch occurs. Should I do the same here? It would be the safest way I guess, but what do you guys think? 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org