You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2014/10/24 12:36:33 UTC

[jira] [Commented] (SPARK-4066) Make whether maven builds fails on scalastyle violation configurable

    [ https://issues.apache.org/jira/browse/SPARK-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182658#comment-14182658 ] 

Sean Owen commented on SPARK-4066:
----------------------------------

Does this work? -Dscalastyle.failOnViolation was already a built-in way to control this, so if it didn't work a) I'm surprised and b) not clear this will work either.

I suppose I don't think this is something that needs to be configurable. The pain is just that someone writes new code that violates style rules? this has to be fixed anyway and fixing style stuff is not hard.

> Make whether maven builds fails on scalastyle violation configurable
> --------------------------------------------------------------------
>
>                 Key: SPARK-4066
>                 URL: https://issues.apache.org/jira/browse/SPARK-4066
>             Project: Spark
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: spark-4066-v1.txt
>
>
> Here is the thread Koert started:
> http://search-hadoop.com/m/JW1q5j8z422/scalastyle+annoys+me+a+little+bit&subj=scalastyle+annoys+me+a+little+bit
> It would be flexible if whether maven build fails due to scalastyle violation configurable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org