You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/21 14:27:04 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #19283: fix: Don't allow duplicated tag values in the Select
michael-s-molina opened a new pull request #19283:
URL: https://github.com/apache/superset/pull/19283
### SUMMARY
This PR fixes two bugs in the Select component:
- Duplicated tags were allowed
- When pasting multiple values, only the last value was being added
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/159281594-e5774b41-f70a-493e-b211-254ba7753307.mov
https://user-images.githubusercontent.com/70410625/159281684-ae031fc3-7539-4069-860b-3a3f705c2588.mov
### TESTING INSTRUCTIONS
Check the videos for instructions.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #19283: fix: Don't allow duplicated tag values in the Select
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #19283:
URL: https://github.com/apache/superset/pull/19283#discussion_r831474519
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -385,31 +385,37 @@ const Select = (
const hasCustomLabels = fullSelectOptions.some(opt => !!opt?.customLabel);
+ const valueAsArray = <T,>(value: any): T[] => {
+ const array = value ? (Array.isArray(value) ? value : [value]) : [];
+ return array as T[];
+ };
+
const handleOnSelect = (
selectedValue: string | number | AntdLabeledValue,
) => {
if (isSingleMode) {
setSelectValue(selectedValue);
+ } else if (
+ typeof selectedValue === 'number' ||
+ typeof selectedValue === 'string'
+ ) {
+ setSelectValue(previousState => {
+ const primitiveArray = valueAsArray<string | number>(previousState);
+ // Tokenized values can contain duplicated values
+ if (!primitiveArray.some(value => value === selectedValue)) {
+ return [...primitiveArray, selectedValue as string | number];
+ }
+ return previousState;
+ });
} else {
- const currentSelected = selectValue
- ? Array.isArray(selectValue)
- ? selectValue
- : [selectValue]
- : [];
- if (
- typeof selectedValue === 'number' ||
- typeof selectedValue === 'string'
- ) {
- setSelectValue([
- ...(currentSelected as (string | number)[]),
- selectedValue as string | number,
- ]);
- } else {
- setSelectValue([
- ...(currentSelected as AntdLabeledValue[]),
- selectedValue as AntdLabeledValue,
- ]);
- }
+ setSelectValue(previousState => {
+ const objectArray = valueAsArray<AntdLabeledValue>(previousState);
+ // Tokenized values can contain duplicated values
+ if (!objectArray.some(object => object.value === selectedValue.label)) {
Review comment:
:see_no_evil: Lack of coffee
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19283: fix: Don't allow duplicated tag values in the Select
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19283:
URL: https://github.com/apache/superset/pull/19283#issuecomment-1074027463
# [Codecov](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19283](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05602ca) into [master](https://codecov.io/gh/apache/superset/commit/783168e13fd06794507807f782956b7a41e2ab8f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (783168e) will **increase** coverage by `0.00%`.
> The diff coverage is `80.00%`.
```diff
@@ Coverage Diff @@
## master #19283 +/- ##
=======================================
Coverage 66.57% 66.57%
=======================================
Files 1667 1667
Lines 64418 64429 +11
Branches 6503 6503
=======================================
+ Hits 42886 42896 +10
Misses 19849 19849
- Partials 1683 1684 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.37% <80.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/19283/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `86.91% <80.00%> (+0.53%)` | :arrow_up: |
| [...nd/src/components/MessageToasts/ToastPresenter.tsx](https://codecov.io/gh/apache/superset/pull/19283/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVzc2FnZVRvYXN0cy9Ub2FzdFByZXNlbnRlci50c3g=) | `93.33% <0.00%> (-6.67%)` | :arrow_down: |
| [superset-frontend/src/embedded/index.tsx](https://codecov.io/gh/apache/superset/pull/19283/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2VtYmVkZGVkL2luZGV4LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ontend/src/components/MessageToasts/withToasts.tsx](https://codecov.io/gh/apache/superset/pull/19283/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVzc2FnZVRvYXN0cy93aXRoVG9hc3RzLnRzeA==) | `100.00% <0.00%> (ø)` | |
| [...rset-ui-core/src/connection/SupersetClientClass.ts](https://codecov.io/gh/apache/superset/pull/19283/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvY29ubmVjdGlvbi9TdXBlcnNldENsaWVudENsYXNzLnRz) | `100.00% <0.00%> (ø)` | |
| [...nd/src/components/MessageToasts/ToastContainer.jsx](https://codecov.io/gh/apache/superset/pull/19283/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVzc2FnZVRvYXN0cy9Ub2FzdENvbnRhaW5lci5qc3g=) | | |
| [...nd/src/components/MessageToasts/ToastContainer.tsx](https://codecov.io/gh/apache/superset/pull/19283/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVzc2FnZVRvYXN0cy9Ub2FzdENvbnRhaW5lci50c3g=) | `100.00% <0.00%> (ø)` | |
| [superset-frontend/src/views/components/Menu.tsx](https://codecov.io/gh/apache/superset/pull/19283/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2NvbXBvbmVudHMvTWVudS50c3g=) | `60.00% <0.00%> (+1.02%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [783168e...05602ca](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #19283: fix: Don't allow duplicated tag values in the Select
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged pull request #19283:
URL: https://github.com/apache/superset/pull/19283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #19283: fix: Don't allow duplicated tag values in the Select
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #19283:
URL: https://github.com/apache/superset/pull/19283#discussion_r831254519
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -385,31 +385,37 @@ const Select = (
const hasCustomLabels = fullSelectOptions.some(opt => !!opt?.customLabel);
+ const valueAsArray = <T,>(value: any): T[] => {
+ const array = value ? (Array.isArray(value) ? value : [value]) : [];
+ return array as T[];
+ };
+
const handleOnSelect = (
selectedValue: string | number | AntdLabeledValue,
) => {
if (isSingleMode) {
setSelectValue(selectedValue);
+ } else if (
+ typeof selectedValue === 'number' ||
+ typeof selectedValue === 'string'
+ ) {
+ setSelectValue(previousState => {
+ const primitiveArray = valueAsArray<string | number>(previousState);
+ // Tokenized values can contain duplicated values
+ if (!primitiveArray.some(value => value === selectedValue)) {
+ return [...primitiveArray, selectedValue as string | number];
+ }
+ return previousState;
+ });
} else {
- const currentSelected = selectValue
- ? Array.isArray(selectValue)
- ? selectValue
- : [selectValue]
- : [];
- if (
- typeof selectedValue === 'number' ||
- typeof selectedValue === 'string'
- ) {
- setSelectValue([
- ...(currentSelected as (string | number)[]),
- selectedValue as string | number,
- ]);
- } else {
- setSelectValue([
- ...(currentSelected as AntdLabeledValue[]),
- selectedValue as AntdLabeledValue,
- ]);
- }
+ setSelectValue(previousState => {
+ const objectArray = valueAsArray<AntdLabeledValue>(previousState);
+ // Tokenized values can contain duplicated values
+ if (!objectArray.some(object => object.value === selectedValue.label)) {
Review comment:
Why are we comparing value to labels?
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -385,31 +385,37 @@ const Select = (
const hasCustomLabels = fullSelectOptions.some(opt => !!opt?.customLabel);
+ const valueAsArray = <T,>(value: any): T[] => {
+ const array = value ? (Array.isArray(value) ? value : [value]) : [];
+ return array as T[];
+ };
Review comment:
There is a `ensureIsArray` function in `@superset-ui/core`
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -385,31 +385,37 @@ const Select = (
const hasCustomLabels = fullSelectOptions.some(opt => !!opt?.customLabel);
+ const valueAsArray = <T,>(value: any): T[] => {
+ const array = value ? (Array.isArray(value) ? value : [value]) : [];
+ return array as T[];
+ };
+
const handleOnSelect = (
selectedValue: string | number | AntdLabeledValue,
) => {
if (isSingleMode) {
setSelectValue(selectedValue);
+ } else if (
+ typeof selectedValue === 'number' ||
+ typeof selectedValue === 'string'
+ ) {
+ setSelectValue(previousState => {
+ const primitiveArray = valueAsArray<string | number>(previousState);
+ // Tokenized values can contain duplicated values
+ if (!primitiveArray.some(value => value === selectedValue)) {
Review comment:
```suggestion
if (!primitiveArray.includes(selectedValue)) {
```
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -385,31 +385,37 @@ const Select = (
const hasCustomLabels = fullSelectOptions.some(opt => !!opt?.customLabel);
+ const valueAsArray = <T,>(value: any): T[] => {
+ const array = value ? (Array.isArray(value) ? value : [value]) : [];
+ return array as T[];
+ };
+
const handleOnSelect = (
selectedValue: string | number | AntdLabeledValue,
) => {
if (isSingleMode) {
setSelectValue(selectedValue);
+ } else if (
+ typeof selectedValue === 'number' ||
+ typeof selectedValue === 'string'
+ ) {
Review comment:
I believe these two if/else can be rewritten with `hasOption` in Select/utils.
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -385,31 +385,37 @@ const Select = (
const hasCustomLabels = fullSelectOptions.some(opt => !!opt?.customLabel);
+ const valueAsArray = <T,>(value: any): T[] => {
+ const array = value ? (Array.isArray(value) ? value : [value]) : [];
+ return array as T[];
+ };
+
const handleOnSelect = (
selectedValue: string | number | AntdLabeledValue,
Review comment:
Can we rename this local `selectedValue` to `selectedItem` so not to confuse with `selectValue` in the parent context which may also be an array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #19283: fix: Don't allow duplicated tag values in the Select
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #19283:
URL: https://github.com/apache/superset/pull/19283#discussion_r831477511
##########
File path: superset-frontend/src/components/Select/Select.test.tsx
##########
@@ -314,6 +314,17 @@ test('searches for custom fields', async () => {
expect(screen.getByText(NO_DATA)).toBeInTheDocument();
});
+test('removes duplicated values', async () => {
+ render(<Select {...defaultProps} mode="multiple" allowNewOptions />);
+ await type('a,b,b,b,c,d,d');
+ const values = await findAllSelectValues();
+ expect(values.length).toBe(4);
+ expect(values[0]).toHaveTextContent('a');
+ expect(values[1]).toHaveTextContent('b');
+ expect(values[2]).toHaveTextContent('c');
+ expect(values[3]).toHaveTextContent('d');
Review comment:
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19283: fix: Don't allow duplicated tag values in the Select
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #19283:
URL: https://github.com/apache/superset/pull/19283#issuecomment-1074027463
# [Codecov](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19283](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e3dd74) into [master](https://codecov.io/gh/apache/superset/commit/783168e13fd06794507807f782956b7a41e2ab8f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (783168e) will **decrease** coverage by `0.00%`.
> The diff coverage is `40.00%`.
> :exclamation: Current head 6e3dd74 differs from pull request most recent head 323f43f. Consider uploading reports for the commit 323f43f to get more accurate results
```diff
@@ Coverage Diff @@
## master #19283 +/- ##
==========================================
- Coverage 66.57% 66.56% -0.01%
==========================================
Files 1667 1667
Lines 64418 64427 +9
Branches 6503 6502 -1
==========================================
+ Hits 42886 42889 +3
- Misses 19849 19854 +5
- Partials 1683 1684 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.35% <40.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/19283/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `84.42% <40.00%> (-1.96%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [783168e...323f43f](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #19283: fix: Don't allow duplicated tag values in the Select
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #19283:
URL: https://github.com/apache/superset/pull/19283#issuecomment-1074027463
# [Codecov](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19283](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6e3dd74) into [master](https://codecov.io/gh/apache/superset/commit/783168e13fd06794507807f782956b7a41e2ab8f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (783168e) will **decrease** coverage by `0.00%`.
> The diff coverage is `40.00%`.
> :exclamation: Current head 6e3dd74 differs from pull request most recent head 05602ca. Consider uploading reports for the commit 05602ca to get more accurate results
```diff
@@ Coverage Diff @@
## master #19283 +/- ##
==========================================
- Coverage 66.57% 66.56% -0.01%
==========================================
Files 1667 1667
Lines 64418 64427 +9
Branches 6503 6502 -1
==========================================
+ Hits 42886 42889 +3
- Misses 19849 19854 +5
- Partials 1683 1684 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.35% <40.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/19283/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `84.42% <40.00%> (-1.96%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [783168e...05602ca](https://codecov.io/gh/apache/superset/pull/19283?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #19283: fix: Don't allow duplicated tag values in the Select
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #19283:
URL: https://github.com/apache/superset/pull/19283#issuecomment-1074335989
@ktmud I addressed all your comments. Thanks for the tips, they were valuable! I also added a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org