You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/06/28 09:43:09 UTC
[GitHub] [rocketmq-mqtt] YYYYWD opened a new pull request, #118: Add retained message
YYYYWD opened a new pull request, #118:
URL: https://github.com/apache/rocketmq-mqtt/pull/118
Implement retained messages via kv store
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] pingww commented on pull request #118: Add retained message
Posted by GitBox <gi...@apache.org>.
pingww commented on PR #118:
URL: https://github.com/apache/rocketmq-mqtt/pull/118#issuecomment-1178614456
add some unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] DongyuanPan commented on pull request #118: Add retained message
Posted by GitBox <gi...@apache.org>.
DongyuanPan commented on PR #118:
URL: https://github.com/apache/rocketmq-mqtt/pull/118#issuecomment-1171090470
please fix travis ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] codecov-commenter commented on pull request #118: Add retained message
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #118:
URL: https://github.com/apache/rocketmq-mqtt/pull/118#issuecomment-1173387150
# [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#118](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3ed037e) into [main](https://codecov.io/gh/apache/rocketmq-mqtt/commit/aba21659222527229e0ee775e4724b99d52b4163?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aba2165) will **decrease** coverage by `1.45%`.
> The diff coverage is `32.87%`.
```diff
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 45.54% 44.09% -1.46%
==========================================
Files 106 109 +3
Lines 4514 4887 +373
Branches 673 726 +53
==========================================
+ Hits 2056 2155 +99
- Misses 2104 2371 +267
- Partials 354 361 +7
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...g/apache/rocketmq/mqtt/common/model/Constants.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL21xdHQvY29tbW9uL21vZGVsL0NvbnN0YW50cy5qYXZh) | `0.00% <ø> (ø)` | |
| [...rg/apache/rocketmq/mqtt/cs/session/QueueFresh.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL1F1ZXVlRnJlc2guamF2YQ==) | `90.00% <ø> (ø)` | |
| [...ketmq/mqtt/ds/meta/RetainedPersistManagerImpl.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9tZXRhL1JldGFpbmVkUGVyc2lzdE1hbmFnZXJJbXBsLmphdmE=) | `3.33% <3.33%> (ø)` | |
| [...cs/protocol/mqtt/handler/MqttSubscribeHandler.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9wcm90b2NvbC9tcXR0L2hhbmRsZXIvTXF0dFN1YnNjcmliZUhhbmRsZXIuamF2YQ==) | `42.70% <4.08%> (-40.97%)` | :arrow_down: |
| [...e/rocketmq/mqtt/ds/store/LmqQueueStoreManager.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy9zdG9yZS9MbXFRdWV1ZVN0b3JlTWFuYWdlci5qYXZh) | `51.85% <41.17%> (+0.68%)` | :arrow_up: |
| [...q/mqtt/ds/upstream/processor/PublishProcessor.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1kcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9kcy91cHN0cmVhbS9wcm9jZXNzb3IvUHVibGlzaFByb2Nlc3Nvci5qYXZh) | `66.66% <47.36%> (-33.34%)` | :arrow_down: |
| [...che/rocketmq/mqtt/cs/session/infly/PushAction.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbXF0dC9jcy9zZXNzaW9uL2luZmx5L1B1c2hBY3Rpb24uamF2YQ==) | `57.57% <57.14%> (-0.32%)` | :arrow_down: |
| [...va/org/apache/rocketmq/mqtt/common/model/Trie.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL21xdHQvY29tbW9uL21vZGVsL1RyaWUuamF2YQ==) | `81.62% <73.91%> (-4.71%)` | :arrow_down: |
| [...org/apache/rocketmq/mqtt/common/model/Message.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL21xdHQvY29tbW9uL21vZGVsL01lc3NhZ2UuamF2YQ==) | `74.46% <88.88%> (+1.21%)` | :arrow_up: |
| [...org/apache/rocketmq/mqtt/common/util/TrieUtil.java](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bXF0dC1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL21xdHQvY29tbW9uL3V0aWwvVHJpZVV0aWwuamF2YQ==) | `93.75% <93.75%> (ø)` | |
| ... and [5 more](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aba2165...3ed037e](https://codecov.io/gh/apache/rocketmq-mqtt/pull/118?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] ShannonDing commented on pull request #118: [ISSUE #70]Add retained message
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on PR #118:
URL: https://github.com/apache/rocketmq-mqtt/pull/118#issuecomment-1200904998
close due to #131.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] YYYYWD commented on pull request #118: Add retained message
Posted by GitBox <gi...@apache.org>.
YYYYWD commented on PR #118:
URL: https://github.com/apache/rocketmq-mqtt/pull/118#issuecomment-1168625933
#70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] DongyuanPan commented on pull request #118: Add retained message
Posted by GitBox <gi...@apache.org>.
DongyuanPan commented on PR #118:
URL: https://github.com/apache/rocketmq-mqtt/pull/118#issuecomment-1194947188
The KV will be removed and the code can be submitted to the Develop branch based on the state machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-mqtt] ShannonDing closed pull request #118: [ISSUE #70]Add retained message
Posted by GitBox <gi...@apache.org>.
ShannonDing closed pull request #118: [ISSUE #70]Add retained message
URL: https://github.com/apache/rocketmq-mqtt/pull/118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org