[GitHub] [spark] dongjoon-hyun commented on a change in pull request #26842: [SPARK-29392][CORE][SQL] More removal of 'foo Symbol syntax for Scala 2.13

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #26842: [SPARK-29392][CORE][SQL] More removal of 'foo Symbol syntax for Scala 2.13
URL: https://github.com/apache/spark/pull/26842#discussion_r356380007
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
 ##########
 @@ -1538,11 +1538,9 @@ class DatasetSuite extends QueryTest with SharedSparkSession {
     checkAnswer(df.sort("id"), expected)
     checkAnswer(df.sort(col("id")), expected)
     checkAnswer(df.sort($"id"), expected)
-    checkAnswer(df.sort('id), expected)
 
 Review comment:
   Yes. This is a real removal of this. This rings me something. 
   @srowen . I'm wondering if we need to have a test coverage for this syntax because this syntax is still supported in any way.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org