You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/04 01:59:21 UTC
[GitHub] [spark] imback82 commented on a change in pull request #30598: [SPARK-33654][SQL] Migrate CACHE TABLE to use UnresolvedRelation to resolve identifier
imback82 commented on a change in pull request #30598:
URL: https://github.com/apache/spark/pull/30598#discussion_r535779449
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala
##########
@@ -706,3 +705,13 @@ case class ShowPartitions(
override val output: Seq[Attribute] = Seq(
AttributeReference("partition", StringType, nullable = false)())
}
+
+/**
+ * The logical plan of the CACHE TABLE command.
+ */
+case class CacheTable(
+ table: LogicalPlan,
+ multipartIdentifier: Seq[String],
+ query: Option[LogicalPlan],
Review comment:
I also tried to resolve `query` in Analyzer by making it a `child` (similar to `InsertIntoStatement`). However, it has the same issue for v2 tables where `DataSourceV2Relation` is changed to `DataSourceV2ScanRelation` in `V2ScanRelationPushDown`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org