You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Mayuresh Gharat <gh...@gmail.com> on 2014/12/21 23:42:47 UTC
Re: Review Request 25944: Patch for KAFKA-1013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/
-----------------------------------------------------------
(Updated Dec. 21, 2014, 10:42 p.m.)
Review request for kafka.
Bugs: KAFKA-1013
https://issues.apache.org/jira/browse/KAFKA-1013
Repository: kafka
Description (updated)
-------
Reverted Changes to ZookeeperConsumerConnector.scala
Diffs (updated)
-----
core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
Diff: https://reviews.apache.org/r/25944/diff/
Testing
-------
Thanks,
Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
Posted by Mayuresh Gharat <gh...@gmail.com>.
> On Dec. 24, 2014, 1:59 a.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/tools/OffsetClient.scala, line 141
> > <https://reviews.apache.org/r/25944/diff/9/?file=798240#file798240line141>
> >
> > This really should not be part of the offset client's public API. fetchTopicMetadata is a utils-level concept. It can take a channel as an argument over which the metadata request will be sent.
Cool. I suppose we should leave it in the ClientUtils and use that in the tools instead of having clientUtils call this internally.
> On Dec. 24, 2014, 1:59 a.m., Joel Koshy wrote:
> > core/src/main/scala/kafka/tools/ExportOffsets.scala, line 56
> > <https://reviews.apache.org/r/25944/diff/9/?file=798236#file798236line56>
> >
> > I thought we would be consolidating the export/import tool into a single consumer offsets tool?
Yeah. I thought of keeping it simple since there were 2 separate classes namely "ImportZKOffsets" and "ExportZKOffsets"
I will mearge them in to one and use an additional commandline parameter for there usage.
- Mayuresh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/#review65997
-----------------------------------------------------------
On Dec. 24, 2014, 12:41 a.m., Mayuresh Gharat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25944/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 12:41 a.m.)
>
>
> Review request for kafka and joel koshy.
>
>
> Bugs: KAFKA-1013
> https://issues.apache.org/jira/browse/KAFKA-1013
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Reverted Changes to ZookeeperConsumerConnector.scala
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
> core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
> core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
> core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79
> core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION
> core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
> core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION
> core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e
> core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
> core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
> core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
> core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191
> core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
>
> Diff: https://reviews.apache.org/r/25944/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mayuresh Gharat
>
>
Re: Review Request 25944: Patch for KAFKA-1013
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/#review65997
-----------------------------------------------------------
core/src/main/scala/kafka/client/ClientUtils.scala
<https://reviews.apache.org/r/25944/#comment109304>
See comment in OffsetClient
core/src/main/scala/kafka/tools/ExportOffsets.scala
<https://reviews.apache.org/r/25944/#comment109308>
I thought we would be consolidating the export/import tool into a single consumer offsets tool?
core/src/main/scala/kafka/tools/OffsetClient.scala
<https://reviews.apache.org/r/25944/#comment109306>
Ideally, we should have a _class_ OffsetClient - actually, a trait and the interface should be:
commitOffsets
fetchOffsets
close
It would be convenient for the user to just instantiate it (the constructor would take a group), use it and then close it.
core/src/main/scala/kafka/tools/OffsetClient.scala
<https://reviews.apache.org/r/25944/#comment109303>
This really should not be part of the offset client's public API. fetchTopicMetadata is a utils-level concept. It can take a channel as an argument over which the metadata request will be sent.
- Joel Koshy
On Dec. 24, 2014, 12:41 a.m., Mayuresh Gharat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25944/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2014, 12:41 a.m.)
>
>
> Review request for kafka and joel koshy.
>
>
> Bugs: KAFKA-1013
> https://issues.apache.org/jira/browse/KAFKA-1013
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Reverted Changes to ZookeeperConsumerConnector.scala
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
> core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
> core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
> core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79
> core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION
> core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
> core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION
> core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e
> core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
> core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
> core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
> core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191
> core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
>
> Diff: https://reviews.apache.org/r/25944/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mayuresh Gharat
>
>
Re: Review Request 25944: Patch for KAFKA-1013
Posted by Eric Olander <ol...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/#review67997
-----------------------------------------------------------
core/src/main/scala/kafka/client/ClientUtils.scala
<https://reviews.apache.org/r/25944/#comment112130>
; not needed
core/src/main/scala/kafka/client/ClientUtils.scala
<https://reviews.apache.org/r/25944/#comment112131>
This will blow up if getOffsetManagerChannel returns None.
scala> None.get
java.util.NoSuchElementException: None.get
at scala.None$.get(Option.scala:322)
... 33 elided
Maybe this method can return Option[BlockingChannel] instead of BlockingChannel?
- Eric Olander
On Jan. 14, 2015, 12:43 a.m., Mayuresh Gharat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25944/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2015, 12:43 a.m.)
>
>
> Review request for kafka, Guozhang Wang, joel koshy, and Neha Narkhede.
>
>
> Bugs: KAFKA-1013
> https://issues.apache.org/jira/browse/KAFKA-1013
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Reverted changes to ZookeeperConsumerConnector.scala
>
>
> Combined the import/export offset tool in to a single tool. Refactored OffsetClient
>
>
> Deleted old Export/Import offsets tool
>
>
> Added apache license
>
>
> Added a default value for the constructor parameter
>
>
> ConsumerOffsetChecker will print the OffsetManager and OffsetsTopicPartition it is reading from
>
>
> Resolving COnflicts for OffsetCommitTest.scala
>
>
> Changed the description in comments regarding input parameters for the class and added a check for groupId when th operation is import
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
> core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
> core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
> core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79
> core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
> core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION
> core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e
> core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION
> core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
> core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
> core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
> core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191
> core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 4a3a5b264a021e55c39f4d7424ce04ee591503ef
>
> Diff: https://reviews.apache.org/r/25944/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mayuresh Gharat
>
>
Re: Review Request 25944: Patch for KAFKA-1013
Posted by Mayuresh Gharat <gh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/
-----------------------------------------------------------
(Updated Jan. 14, 2015, 12:43 a.m.)
Review request for kafka, Guozhang Wang, joel koshy, and Neha Narkhede.
Bugs: KAFKA-1013
https://issues.apache.org/jira/browse/KAFKA-1013
Repository: kafka
Description (updated)
-------
Reverted changes to ZookeeperConsumerConnector.scala
Combined the import/export offset tool in to a single tool. Refactored OffsetClient
Deleted old Export/Import offsets tool
Added apache license
Added a default value for the constructor parameter
ConsumerOffsetChecker will print the OffsetManager and OffsetsTopicPartition it is reading from
Resolving COnflicts for OffsetCommitTest.scala
Changed the description in comments regarding input parameters for the class and added a check for groupId when th operation is import
Diffs (updated)
-----
core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79
core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e
core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 4a3a5b264a021e55c39f4d7424ce04ee591503ef
Diff: https://reviews.apache.org/r/25944/diff/
Testing
-------
Thanks,
Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
Posted by Mayuresh Gharat <gh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/
-----------------------------------------------------------
(Updated Jan. 13, 2015, 9:56 p.m.)
Review request for kafka, Guozhang Wang, joel koshy, and Neha Narkhede.
Bugs: KAFKA-1013
https://issues.apache.org/jira/browse/KAFKA-1013
Repository: kafka
Description (updated)
-------
Reverted changes to ZookeeperConsumerConnector.scala
Combined the import/export offset tool in to a single tool. Refactored OffsetClient
Deleted old Export/Import offsets tool
Added apache license
Added a default value for the constructor parameter
ConsumerOffsetChecker will print the OffsetManager and OffsetsTopicPartition it is reading from
Resolving COnflicts for OffsetCommitTest.scala
Diffs (updated)
-----
core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79
core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e
core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 4a3a5b264a021e55c39f4d7424ce04ee591503ef
Diff: https://reviews.apache.org/r/25944/diff/
Testing
-------
Thanks,
Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
Posted by Mayuresh Gharat <gh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/
-----------------------------------------------------------
(Updated Jan. 8, 2015, 2:35 a.m.)
Review request for kafka, Guozhang Wang, joel koshy, and Neha Narkhede.
Bugs: KAFKA-1013
https://issues.apache.org/jira/browse/KAFKA-1013
Repository: kafka
Description
-------
Reverted changes to ZookeeperConsumerConnector.scala
Combined the import/export offset tool in to a single tool. Refactored OffsetClient
Deleted old Export/Import offsets tool
Added apache license
Diffs
-----
core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79
core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e
core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
-------
Thanks,
Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
Posted by Mayuresh Gharat <gh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/
-----------------------------------------------------------
(Updated Dec. 28, 2014, 12:21 a.m.)
Review request for kafka and joel koshy.
Bugs: KAFKA-1013
https://issues.apache.org/jira/browse/KAFKA-1013
Repository: kafka
Description (updated)
-------
Reverted changes to ZookeeperConsumerConnector.scala
Combined the import/export offset tool in to a single tool. Refactored OffsetClient
Deleted old Export/Import offsets tool
Added apache license
Diffs (updated)
-----
core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79
core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e
core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
-------
Thanks,
Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
Posted by Mayuresh Gharat <gh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/
-----------------------------------------------------------
(Updated Dec. 28, 2014, 12:15 a.m.)
Review request for kafka and joel koshy.
Bugs: KAFKA-1013
https://issues.apache.org/jira/browse/KAFKA-1013
Repository: kafka
Description (updated)
-------
Reverted changes to ZookeeperConsumerConnector.scala
Combined the import/export offset tool in to a single tool. Refactored OffsetClient
Deleted old Export/Import offsets tool
Diffs (updated)
-----
core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79
core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
core/src/main/scala/kafka/tools/ImportExportOffsetTool.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e
core/src/main/scala/kafka/tools/KafkaOffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
-------
Thanks,
Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
Posted by Mayuresh Gharat <gh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/
-----------------------------------------------------------
(Updated Dec. 24, 2014, 12:41 a.m.)
Review request for kafka and joel koshy.
Bugs: KAFKA-1013
https://issues.apache.org/jira/browse/KAFKA-1013
Repository: kafka
Description
-------
Reverted Changes to ZookeeperConsumerConnector.scala
Diffs
-----
core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79
core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
-------
Thanks,
Mayuresh Gharat
Re: Review Request 25944: Patch for KAFKA-1013
Posted by Mayuresh Gharat <gh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/
-----------------------------------------------------------
(Updated Dec. 21, 2014, 11:06 p.m.)
Review request for kafka and joel koshy.
Bugs: KAFKA-1013
https://issues.apache.org/jira/browse/KAFKA-1013
Repository: kafka
Description
-------
Reverted Changes to ZookeeperConsumerConnector.scala
Diffs
-----
core/src/main/scala/kafka/client/ClientUtils.scala ebba87f0566684c796c26cb76c64b4640a5ccfde
core/src/main/scala/kafka/consumer/SimpleConsumer.scala e53ee51638b930d8592ce9994ae2a617e7ef771c
core/src/main/scala/kafka/javaapi/consumer/SimpleConsumer.scala 0ab0195dc9f66f407061d0fac2549bd6291e41ff
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala d1e7c434e77859d746b8dc68dd5d5a3740425e79
core/src/main/scala/kafka/tools/ExportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/ExportZkOffsets.scala 4d051bc2db12f0e15aa6a3289abeb9dd25d373d2
core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportZkOffsets.scala abe09721b13f71320510fd1a01c1917470450c6e
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION
core/src/main/scala/kafka/utils/Utils.scala 738c1af9ef5de16fdf5130daab69757a14c48b5c
core/src/test/scala/other/kafka/TestOffsetManager.scala 41f334d48897b3027ed54c58bbf4811487d3b191
core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 8c5364fa97da1be09973c176d1baeb339455d319
Diff: https://reviews.apache.org/r/25944/diff/
Testing
-------
Thanks,
Mayuresh Gharat