[GitHub] mdeuser commented on a change in pull request #4108: Making Redis password protected

[GitBox <gi...@apache.org>]

mdeuser commented on a change in pull request #4108: Making Redis password protected
URL: https://github.com/apache/incubator-openwhisk/pull/4108#discussion_r239164818
 
 

 ##########
 File path: ansible/roles/redis/tasks/deploy.yml
 ##########
 @@ -21,10 +21,13 @@
       - "{{ redis.port }}:6379"
     env:
       TZ: "{{ docker.timezone }}"
+    command:
+      /bin/sh -c
+      "docker-entrypoint.sh --requirepass {{ redis.password }}"
 
 - name: wait until redis is up and running
-  action: shell (echo PING; sleep 1) | nc {{ ansible_host }} {{ redis.port }}
+  action: shell (printf "*2\r\n\$4\r\nAUTH\r\n\${{redis.password|length}}\r\n{{ redis.password }}\r\n*1\r\n\$4\r\nPING\r\n"; sleep 1) | nc {{ ansible_host }} {{ redis.port }}
 
 Review comment:
   @kpavel - can you provide a sample `printf` output that this line generates?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services