You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Duo Zhang (JIRA)" <ji...@apache.org> on 2019/01/01 01:43:00 UTC

[jira] [Commented] (HBASE-21664) Move the methods in QuotaTableUtil which are only used by tests to test code base

    [ https://issues.apache.org/jira/browse/HBASE-21664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16731495#comment-16731495 ] 

Duo Zhang commented on HBASE-21664:
-----------------------------------

OK, seems we use them in shell. Let me check.

> Move the methods in QuotaTableUtil which are only used by tests to test code base
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-21664
>                 URL: https://issues.apache.org/jira/browse/HBASE-21664
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>         Attachments: HBASE-21644.patch
>
>
> When trying to minimize the number of methods in ClusterConnection, I found that QuotaStatusCalls uses several methods in ClusterConnection, and it is not under the client package. And finally I found that, only QuotaTableUtil uses it, and all the methods which reference it is used for testing.
>  So let's move these methods to the test code base, so we are free to move it anywhere, so we do not need to declare the methods in ClusterConnection any more.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)