You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by "Marcus Christie (Jira)" <ji...@apache.org> on 2021/07/13 22:00:02 UTC
[jira] [Updated] (AIRAVATA-3458) Don't preview large files in user
storage browser
[ https://issues.apache.org/jira/browse/AIRAVATA-3458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcus Christie updated AIRAVATA-3458:
--------------------------------------
Description:
The user storage browser automatically tries to download files that are the right type to preview but doesn't check their size first. So with a large file, it attempts to load the entire file into the codemirror editor and this causes the browser to hang.
The file size should be checked first and no preview/edit offered for large files.
Somewhat arbitrarily I chose a *large file cutoff of 1MB*. We can easily adjust as necessary: https://github.com/apache/airavata-django-portal/blob/develop/django_airavata/apps/workspace/static/django_airavata_workspace/js/components/storage/storage-edit/UserStorageTextEditViewer.vue#L36
TODO
- [x] add a get_data_product_metadata function to user_storage, similar to get_file_metadata but taking a data_product or data_product_uri
- [x] add a check in UserStorageTextEditViewer.vue to load the filesize first and display a message if the file is too large, otherwise load the file into the editor like it is currently doing
- [x] add gzip compression to file download ((/) in api and (/) in SDK)
- [x] add owner_username override to get_data_product_metadata
- [x] Want to revisit how the UI handles disabling preview for large files.
was:
The user storage browser automatically tries to download files that are the right type to preview but doesn't check their size first. So with a large file, it attempts to load the entire file into the codemirror editor and this causes the browser to hang.
The file size should be checked first and no preview/edit offered for large files.
TODO
- [x] add a get_data_product_metadata function to user_storage, similar to get_file_metadata but taking a data_product or data_product_uri
- [x] add a check in UserStorageTextEditViewer.vue to load the filesize first and display a message if the file is too large, otherwise load the file into the editor like it is currently doing
- [x] add gzip compression to file download ((/) in api and (/) in SDK)
- [x] add owner_username override to get_data_product_metadata
- [x] Want to revisit how the UI handles disabling preview for large files.
> Don't preview large files in user storage browser
> -------------------------------------------------
>
> Key: AIRAVATA-3458
> URL: https://issues.apache.org/jira/browse/AIRAVATA-3458
> Project: Airavata
> Issue Type: Bug
> Components: Django Portal
> Reporter: Marcus Christie
> Assignee: Marcus Christie
> Priority: Major
>
> The user storage browser automatically tries to download files that are the right type to preview but doesn't check their size first. So with a large file, it attempts to load the entire file into the codemirror editor and this causes the browser to hang.
> The file size should be checked first and no preview/edit offered for large files.
> Somewhat arbitrarily I chose a *large file cutoff of 1MB*. We can easily adjust as necessary: https://github.com/apache/airavata-django-portal/blob/develop/django_airavata/apps/workspace/static/django_airavata_workspace/js/components/storage/storage-edit/UserStorageTextEditViewer.vue#L36
> TODO
> - [x] add a get_data_product_metadata function to user_storage, similar to get_file_metadata but taking a data_product or data_product_uri
> - [x] add a check in UserStorageTextEditViewer.vue to load the filesize first and display a message if the file is too large, otherwise load the file into the editor like it is currently doing
> - [x] add gzip compression to file download ((/) in api and (/) in SDK)
> - [x] add owner_username override to get_data_product_metadata
> - [x] Want to revisit how the UI handles disabling preview for large files.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)