[GitHub] JaredTan95 removed a comment on issue #1919: feat:support set config from system.envs.

[GitBox <gi...@apache.org>]

JaredTan95 removed a comment on issue #1919: feat:support set config from system.envs.
URL: https://github.com/apache/incubator-skywalking/pull/1919#issuecomment-441160013
 
 
   Is the environment variable name format OK? :)
   
   ```
   
   cluster:
     standalone:
      # Please check your ZooKeeper is 3.5+, However, it is also compatible with ZooKeeper 3.4.x. Replace the ZooKeeper 3.5+
      # library the oap-libs folder with your ZooKeeper 3.4.x library.
   #  zookeeper:
   #    hostPort: ${SW_CLUSTER_ZK_HOST_PORT:localhost:2181}
   #    #Retry Policy
   #    baseSleepTimeMs: ${SW_CLUSTER_ZK_SLEEP_TIME:1000} # initial amount of time to wait between retries
   #    maxRetries: ${SW_CLUSTER_ZK_MAX_RETRIES:3} # max number of times to retry
   #  kubernetes:
   #    watchTimeoutSeconds: ${SW_CLUSTER_K8S_WATCH_TIMEOUT:60}
   #    namespace: ${SW_CLUSTER_K8S_NAMESPACE:default}
   #    labelSelector: ${SW_CLUSTER_K8S_LABEL:app=collector,release=skywalking}
   #    uidEnvName: ${SW_CLUSTER_K8S_UID:SKYWALKING_COLLECTOR_UID}
   core:
     default:
       restHost: ${SW_CORE_REST_HOST:0.0.0.0}
       restPort: ${SW_CORE_REST_PORT:12800}
       restContextPath: ${SW_CORE_REST_CONTEXT_PATH:/}
       gRPCHost: ${SW_CORE_GRPC_HOST:0.0.0.0}
       gRPCPort: ${SW_CORE_GRPC_PORT:11800}
       downsampling:
       - Hour
       - Day
       - Month
       # Set a timeout on metric data. After the timeout has expired, the metric data will automatically be deleted.
       recordDataTTL: ${SW_CORE_RECORD_DATA_TTL:90} # Unit is minute
       minuteMetricsDataTTL: ${SW_CORE_MINUTE_METRIC_DATA_TTL:90} # Unit is minute
       hourMetricsDataTTL: ${SW_CORE_HOUR_METRIC_DATA_TTL:36} # Unit is hour
       dayMetricsDataTTL: ${SW_CORE_DAY_METRIC_DATA_TTL:45} # Unit is day
       monthMetricsDataTTL: ${SW_CORE_MONTH_METRIC_DATA_TTL:18} # Unit is month
   storage:
     elasticsearch:
       clusterNodes: ${SW_STORAGE_ES_CLUSTER_NODES:localhost:9200}
       indexShardsNumber: ${SW_STORAGE_ES_INDEX_SHARDS_NUMBER:2}
       indexReplicasNumber: ${SW_STORAGE_ES_INDEX_REPLICAS_NUMBER:0}
       # Batch process setting, refer to https://www.elastic.co/guide/en/elasticsearch/client/java-api/5.5/java-docs-bulk-processor.html
       bulkActions: ${SW_STORAGE_ES_BULK_ACTIONS:2000} # Execute the bulk every 2000 requests
       bulkSize: ${SW_STORAGE_ES_BULK_SIZE:20} # flush the bulk every 20mb
       flushInterval: ${SW_STORAGE_ES_FLUSH_INTERVAL:10} # flush the bulk every 10 seconds whatever the number of requests
       concurrentRequests: ${SW_STORAGE_ES_CONCURRENT_REQUESTS:2} # the number of concurrent requests
   #  h2:
   #    driver: org.h2.jdbcx.JdbcDataSource
   #    url: jdbc:h2:mem:skywalking-oap-db
   #    user: sa
   receiver-register:
     default:
   receiver-trace:
     default:
       bufferPath: ${SW_RECEIVER_BUFFER_PATH:../trace-buffer/}  # Path to trace buffer files, suggest to use absolute path
       bufferOffsetMaxFileSize: ${SW_RECEIVER_BUFFER_OFFSET_MAX_FILE_SIZE:100} # Unit is MB
       bufferDataMaxFileSize: ${SW_RECEIVER_BUFFER_DATA_MAX_FILE_SIZE:500} # Unit is MB
       bufferFileCleanWhenRestart: ${SW_RECEIVER_BUFFER_FILE_CLEAN_WHEN_RESTART:false}
   receiver-jvm:
     default:
   service-mesh:
     default:
       bufferPath: ${SW_SERVICE_MESH_BUFFER_PATH:../mesh-buffer/}  # Path to trace buffer files, suggest to use absolute path
       bufferOffsetMaxFileSize: ${SW_SERVICE_MESH_OFFSET_MAX_FILE_SIZE:100} # Unit is MB
       bufferDataMaxFileSize: ${SW_SERVICE_MESH_BUFFER_DATA_MAX_FILE_SIZE:500} # Unit is MB
       bufferFileCleanWhenRestart: ${SW_SERVICE_MESH_BUFFER_FILE_CLEAN_WHEN_RESTART:false}
   istio-telemetry:
     default:
   receiver_zipkin:
     default:
       host: ${SW_RECEIVER_ZIPKIN_HOST:0.0.0.0}
       port: ${SW_RECEIVER_ZIPKIN_PORT:9411}
       contextPath: ${SW_RECEIVER_ZIPKIN_CONTEXT_PATH:/}
   query:
     graphql:
       path: ${SW_QUERY_GRAPHQL_PATH:/graphql}
   alarm:
     default:
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services