You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/17 16:39:36 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #9824: style: enforcing mypy typing for connectors

john-bodley opened a new pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824


   ### SUMMARY
   
   Adding mypy type enforcement to the `superset.connectors` module.
   
   Note this PR was much more involved/complex than I had originally thought given the dependency on other modules which were untyped. Additionally the overall code quality is quite poor; large complex functions, variables with mixed types (i.e., numerous `Union` types), variable redefinition, etc. meant that the logic was quite hard to grok. 
   
   Note this PR may introduce some regressions due to the necessary restructuring, however I sense long-term benefits of having the entire repo typed outweighs the short-term concerns regarding possibly (minor) regressions.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   
   CI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `4.87%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   66.14%   -4.88%     
   ==========================================
     Files         583      583              
     Lines       30615    30486     -129     
     Branches     3162     3162              
   ==========================================
   - Hits        21745    20166    -1579     
   - Misses       8759    10139    +1380     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.29% <ø> (ø)` | |
   | #python | `70.95% <84.50%> (-0.32%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.12% <41.66%> (-0.33%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.91% <91.66%> (-0.12%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [68832d2...eef2c96](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c117e222c09590bc56ad06ad1708e5d264b1c798&el=desc) will **decrease** coverage by `4.71%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   66.30%   -4.72%     
   ==========================================
     Files         583      583              
     Lines       30634    30668      +34     
     Branches     3165     3165              
   ==========================================
   - Hits        21758    20335    -1423     
   - Misses       8765    10152    +1387     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.31% <ø> (ø)` | |
   | #python | `71.17% <84.50%> (-0.10%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.02% <91.66%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [159 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [c117e22...8c4c77a](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r426869164



##########
File path: superset/connectors/druid/models.py
##########
@@ -1240,7 +1268,7 @@ def run_query(  # druid
             qry["limit"] = row_limit
             client.scan(**qry)
         elif (IS_SIP_38 and columns) or (
-            not IS_SIP_38 and len(groupby) == 0 and not having_filters
+            not IS_SIP_38 and (not groupby or len(groupby) == 0) and not having_filters

Review comment:
       @villebro thanks. I agree and made this change elsewhere.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r427637637



##########
File path: superset/utils/core.py
##########
@@ -985,11 +988,11 @@ def is_adhoc_metric(metric) -> bool:
     )
 
 
-def get_metric_name(metric):
-    return metric["label"] if is_adhoc_metric(metric) else metric
+def get_metric_name(metric: Metric) -> str:

Review comment:
       @villebro the code works if the `metric` is `None` even though the `Metric` type is explicitly `Union[Dict[str, str], str]`. Generally I think we should strive to ensure only valid inputs are provided to functions (otherwise the logic can get quite complex), i.e., I prefer, 
   
   ```python
   if metric:
       name = get_metric_name(metric)
       ...
   ```
   
   rather than, 
   
   ```python
   name = get_metric_name(metric)
   
   if name:
      ...
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on pull request #9824: style(mypy): enforcing mypy typing for superset.connectors

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-632516280


   Sure thing,@john-bodley , I'll review during the weekend


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f1208f510ceda24654dca794cf04a33aa234cc5&el=desc) will **decrease** coverage by `0.16%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.13%   70.96%   -0.17%     
   ==========================================
     Files         588      404     -184     
     Lines       30792    12741   -18051     
     Branches     3238     3238              
   ==========================================
   - Hits        21904     9042   -12862     
   + Misses       8776     3588    -5188     
   + Partials      112      111       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.05% <ø> (+0.02%)` | :arrow_up: |
   | #javascript | `59.30% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | | |
   | [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
   | [superset/charts/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | | |
   | [superset/db\_engine\_specs/gsheets.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2dzaGVldHMucHk=) | | |
   | [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | | |
   | [superset/tasks/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3Mvc2NoZWR1bGVzLnB5) | | |
   | [superset/examples/paris.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvcGFyaXMucHk=) | | |
   | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | | |
   | [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
   | [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | | |
   | ... and [161 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [6f1208f...6c67fde](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: style(mypy): enforcing mypy typing for superset.connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r430038941



##########
File path: superset/typing.py
##########
@@ -16,15 +16,31 @@
 # under the License.
 from typing import Any, Callable, Dict, List, Optional, Tuple, Union
 
-from flask import Flask
+import flask
+import werkzeug
 from flask_caching import Cache
 
-CacheConfig = Union[Callable[[Flask], Cache], Dict[str, Any]]
+CacheConfig = Union[Callable[[flask.Flask], Cache], Dict[str, Any]]
 DbapiDescriptionRow = Tuple[
     str, str, Optional[str], Optional[str], Optional[int], Optional[int], bool
 ]
 DbapiDescription = Union[List[DbapiDescriptionRow], Tuple[DbapiDescriptionRow, ...]]
 DbapiResult = List[Union[List[Any], Tuple[Any, ...]]]
 FilterValue = Union[float, int, str]
 FilterValues = Union[FilterValue, List[FilterValue], Tuple[FilterValue]]
+Granularity = Union[str, Dict[str, Union[str, float]]]
+Metric = Union[Dict[str, str], str]
+QueryObjectDict = Dict[str, Any]
 VizData = Optional[Union[List[Any], Dict[Any, Any]]]
+
+# Flask response.
+Base = Union[bytes, str]
+Status = Union[int, str]
+Headers = Dict[str, Any]
+FlaskResponse = Union[
+    flask.wrappers.Response,
+    werkzeug.wrappers.Response,
+    Base,
+    Union[Base, Status],
+    Union[Base, Status, Headers],
+]

Review comment:
       @villebro, that's actually a typo as the later `Union` should be a `Tuple` and given that `flask.wrappers.Response` is derived from `werkzeug.wrappers.Response` per [here](https://github.com/pallets/flask/blob/master/src/flask/wrappers.py#L93) this could be:
   
   ```python
   FlaskResponse = Union[
       werkzeug.wrappers.Response,
       Base,
       Tuple[Base, Status],
       Tuple[Base, Status, Headers],
   ]
   ```
   

##########
File path: superset/typing.py
##########
@@ -16,15 +16,31 @@
 # under the License.
 from typing import Any, Callable, Dict, List, Optional, Tuple, Union
 
-from flask import Flask
+import flask
+import werkzeug
 from flask_caching import Cache
 
-CacheConfig = Union[Callable[[Flask], Cache], Dict[str, Any]]
+CacheConfig = Union[Callable[[flask.Flask], Cache], Dict[str, Any]]
 DbapiDescriptionRow = Tuple[
     str, str, Optional[str], Optional[str], Optional[int], Optional[int], bool
 ]
 DbapiDescription = Union[List[DbapiDescriptionRow], Tuple[DbapiDescriptionRow, ...]]
 DbapiResult = List[Union[List[Any], Tuple[Any, ...]]]
 FilterValue = Union[float, int, str]
 FilterValues = Union[FilterValue, List[FilterValue], Tuple[FilterValue]]
+Granularity = Union[str, Dict[str, Union[str, float]]]
+Metric = Union[Dict[str, str], str]
+QueryObjectDict = Dict[str, Any]
 VizData = Optional[Union[List[Any], Dict[Any, Any]]]
+
+# Flask response.
+Base = Union[bytes, str]
+Status = Union[int, str]
+Headers = Dict[str, Any]
+FlaskResponse = Union[
+    flask.wrappers.Response,
+    werkzeug.wrappers.Response,
+    Base,
+    Union[Base, Status],
+    Union[Base, Status, Headers],
+]

Review comment:
       @villebro, that's actually a typo as the later `Union` should be a `Tuple`. Also given that `flask.wrappers.Response` is derived from `werkzeug.wrappers.Response` per [here](https://github.com/pallets/flask/blob/master/src/flask/wrappers.py#L93) this could be:
   
   ```python
   FlaskResponse = Union[
       werkzeug.wrappers.Response,
       Base,
       Tuple[Base, Status],
       Tuple[Base, Status, Headers],
   ]
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `4.95%`.
   > The diff coverage is `83.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   66.07%   -4.96%     
   ==========================================
     Files         583      583              
     Lines       30615    30488     -127     
     Branches     3162     3162              
   ==========================================
   - Hits        21745    20145    -1600     
   - Misses       8759    10162    +1403     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.29% <ø> (ø)` | |
   | #python | `70.82% <83.87%> (-0.45%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.76% <40.00%> (-4.95%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.12% <41.66%> (-0.33%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.92% <92.85%> (-0.11%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.68% <95.12%> (+0.08%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [187 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [68832d2...b66071f](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9824: style: enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `11.62%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9824       +/-   ##
   ===========================================
   - Coverage   70.88%   59.25%   -11.63%     
   ===========================================
     Files         585      401      -184     
     Lines       30432    12564    -17868     
     Branches     3152     3152               
   ===========================================
   - Hits        21571     7445    -14126     
   + Misses       8749     4938     -3811     
   - Partials      112      181       +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.25% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [306 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...368dc7e](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r426380594



##########
File path: superset/connectors/base/models.py
##########
@@ -182,7 +182,7 @@ def short_data(self) -> Dict[str, Any]:
         }
 
     @property
-    def select_star(self):
+    def select_star(self) -> str:
         pass

Review comment:
       This probably needs to be `Optional[str]` or alternatively raise `NotImplementedError`.

##########
File path: superset/typing.py
##########
@@ -16,15 +16,31 @@
 # under the License.
 from typing import Any, Callable, Dict, List, Optional, Tuple, Union
 
-from flask import Flask
+import flask
+import werkzeug
 from flask_caching import Cache
 
-CacheConfig = Union[Callable[[Flask], Cache], Dict[str, Any]]
+CacheConfig = Union[Callable[[flask.Flask], Cache], Dict[str, Any]]
 DbapiDescriptionRow = Tuple[
     str, str, Optional[str], Optional[str], Optional[int], Optional[int], bool
 ]
 DbapiDescription = Union[List[DbapiDescriptionRow], Tuple[DbapiDescriptionRow, ...]]
 DbapiResult = List[Union[List[Any], Tuple[Any, ...]]]
 FilterValue = Union[float, int, str]
 FilterValues = Union[FilterValue, List[FilterValue], Tuple[FilterValue]]
+Granularity = Union[str, Dict[str, Union[str, float]]]
+Metric = Union[Dict[str, str], str]
+QueryObject = Dict[str, Any]

Review comment:
       We should probably call this `QueryObjectDict` to distinguish from `superset.common.query_object.QueryObject`.

##########
File path: superset/connectors/base/models.py
##########
@@ -93,7 +93,7 @@ class BaseDatasource(
     update_from_object_fields: List[str]
 
     @declared_attr
-    def slices(self):
+    def slices(self) -> relationship:

Review comment:
       I believe this should be `RelationshipProperty`. See: https://docs.sqlalchemy.org/en/13/orm/relationship_api.html#sqlalchemy.orm.relationship

##########
File path: superset/connectors/druid/models.py
##########
@@ -558,8 +569,8 @@ def get_perm(self) -> str:
             obj=self
         )
 
-    def update_from_object(self, obj):
-        return NotImplementedError()

Review comment:
       😄 

##########
File path: superset/connectors/druid/models.py
##########
@@ -1322,13 +1347,13 @@ def run_query(  # druid
                     set([x for x in pre_qry_dims if not isinstance(x, dict)])
                 )
                 dict_dims = [x for x in pre_qry_dims if isinstance(x, dict)]
-                pre_qry["dimensions"] = non_dict_dims + dict_dims
+                pre_qry["dimensions"] = non_dict_dims + dict_dims  # type: ignore
 
-                order_by = None
+                order_by = None  # type: ignore

Review comment:
       If we define this as `order_by: Optional[Metric]`, we can probably omit the ignore?

##########
File path: superset/connectors/druid/models.py
##########
@@ -817,7 +829,7 @@ def granularity(
             "year": "P1Y",
         }
 
-        granularity: Dict[str, Union[str, float]] = {"type": "period"}
+        granularity = {"type": "period"}

Review comment:
       I would have thought this turns into a `Dict[str, str]` unless being explicitly being defined as `Granularity`, and thus causing problems below when numeric values are added? 

##########
File path: superset/connectors/druid/models.py
##########
@@ -449,7 +460,7 @@ def get_perm(self) -> Optional[str]:
 
     @classmethod
     def import_obj(cls, i_metric: "DruidMetric") -> "DruidMetric":
-        def lookup_obj(lookup_metric: DruidMetric) -> Optional[DruidMetric]:
+        def lookup_obj(lookup_metric: "DruidMetric") -> Optional["DruidMetric"]:

Review comment:
       Not sure how a nested function referencing its parent method's class is handled by mypy, but if this was working before, we should probably be ok leaving this without quotes?

##########
File path: superset/connectors/druid/models.py
##########
@@ -1240,7 +1268,7 @@ def run_query(  # druid
             qry["limit"] = row_limit
             client.scan(**qry)
         elif (IS_SIP_38 and columns) or (
-            not IS_SIP_38 and len(groupby) == 0 and not having_filters
+            not IS_SIP_38 and (not groupby or len(groupby) == 0) and not having_filters

Review comment:
       I wonder if a simple falsy check here would be more pythonic: `not groupby`? I can't think of an edge case for which it wouldn't give the correct results.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-632173162


   @villebro would you mind taking another pass at this PR? All the CI tasks are now passing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `11.64%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9824       +/-   ##
   ===========================================
   - Coverage   70.88%   59.24%   -11.65%     
   ===========================================
     Files         585      402      -183     
     Lines       30432    12584    -17848     
     Branches     3152     3158        +6     
   ===========================================
   - Hits        21571     7455    -14116     
   + Misses       8749     4948     -3801     
   - Partials      112      181       +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.24% <ø> (-0.02%)` | :arrow_down: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [307 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...a7e5c32](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9824: chore(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `11.62%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9824       +/-   ##
   ===========================================
   - Coverage   70.88%   59.25%   -11.63%     
   ===========================================
     Files         585      401      -184     
     Lines       30432    12564    -17868     
     Branches     3152     3152               
   ===========================================
   - Hits        21571     7445    -14126     
   + Misses       8749     4938     -3811     
   - Partials      112      181       +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.25% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [306 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...c9c7a59](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r427637637



##########
File path: superset/utils/core.py
##########
@@ -985,11 +988,11 @@ def is_adhoc_metric(metric) -> bool:
     )
 
 
-def get_metric_name(metric):
-    return metric["label"] if is_adhoc_metric(metric) else metric
+def get_metric_name(metric: Metric) -> str:

Review comment:
       @villebro the code works if the `metric` is `None` (this can happen when a key exists in the form-data but the value is `None`) even though the `Metric` type is explicitly `Union[Dict[str, str], str]`. Generally I think we should strive to ensure only valid inputs are provided to functions (otherwise the logic can get quite complex), i.e., I prefer, 
   
   ```python
   if metric:
       name = get_metric_name(metric)
       ...
   ```
   
   rather than, 
   
   ```python
   name = get_metric_name(metric)
   
   if name:
      ...
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `4.58%`.
   > The diff coverage is `84.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   70.88%   66.29%   -4.59%     
   ==========================================
     Files         585      586       +1     
     Lines       30432    30670     +238     
     Branches     3152     3158       +6     
   ==========================================
   - Hits        21571    20334    -1237     
   - Misses       8749    10155    +1406     
   - Partials      112      181      +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.24% <ø> (-0.02%)` | :arrow_down: |
   | #python | `71.20% <84.36%> (+0.18%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (+0.14%)` | :arrow_up: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.45% <88.00%> (-0.15%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.02% <91.66%> (+0.11%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.00%> (+0.27%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.05%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.42%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.87%)` | :arrow_up: |
   | ... and [183 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...a7e5c32](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r426872156



##########
File path: superset/connectors/druid/models.py
##########
@@ -1322,13 +1347,13 @@ def run_query(  # druid
                     set([x for x in pre_qry_dims if not isinstance(x, dict)])
                 )
                 dict_dims = [x for x in pre_qry_dims if isinstance(x, dict)]
-                pre_qry["dimensions"] = non_dict_dims + dict_dims
+                pre_qry["dimensions"] = non_dict_dims + dict_dims  # type: ignore
 
-                order_by = None
+                order_by = None  # type: ignore

Review comment:
       @villebro the issue here is that `order_by` has already been defined on line 1291, 
   
   ```python
   order_by = utils.get_metric_name(timeseries_limit_metric)
   ```
   
   I declared the type as `order_by: Optional[str] = None`.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `4.68%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   66.34%   -4.69%     
   ==========================================
     Files         583      583              
     Lines       30615    30651      +36     
     Branches     3162     3162              
   ==========================================
   - Hits        21745    20336    -1409     
   - Misses       8759    10134    +1375     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.29% <ø> (ø)` | |
   | #python | `71.24% <84.50%> (-0.03%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.02% <91.66%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [153 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [68832d2...eef2c96](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r426895317



##########
File path: superset/connectors/base/models.py
##########
@@ -182,7 +182,7 @@ def short_data(self) -> Dict[str, Any]:
         }
 
     @property
-    def select_star(self):
+    def select_star(self) -> str:
         pass

Review comment:
       @villebro a `NotImplementedError` causes havoc for Druid hence why this is `pass`. I made this an `Optional[str]`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f1208f510ceda24654dca794cf04a33aa234cc5&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `83.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   + Coverage   71.13%   71.14%   +0.01%     
   ==========================================
     Files         588      588              
     Lines       30792    30830      +38     
     Branches     3238     3238              
   ==========================================
   + Hits        21904    21935      +31     
   - Misses       8776     8784       +8     
   + Partials      112      111       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.05% <ø> (+0.02%)` | :arrow_up: |
   | #javascript | `59.30% <ø> (ø)` | |
   | #python | `71.27% <83.87%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.04% <92.85%> (+0.01%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [6f1208f...6c67fde](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on pull request #9824: style: enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629826528


   Oh boy, gonna need to take some sedatives before this 😄 Thanks for taking this on @john-bodley , I'll review shortly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #9824: style: enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `11.62%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9824       +/-   ##
   ===========================================
   - Coverage   70.88%   59.25%   -11.63%     
   ===========================================
     Files         585      401      -184     
     Lines       30432    12564    -17868     
     Branches     3152     3152               
   ===========================================
   - Hits        21571     7445    -14126     
   + Misses       8749     4938     -3811     
   - Partials      112      181       +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.25% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [306 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...507086a](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/368c85de1b8fec74dc2df38df92527dede4a00c4&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `85.16%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   + Coverage   66.32%   66.33%   +0.01%     
   ==========================================
     Files         588      588              
     Lines       30786    30822      +36     
     Branches     3238     3238              
   ==========================================
   + Hits        20418    20445      +27     
   - Misses      10181    10190       +9     
     Partials      187      187              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.30% <ø> (ø)` | |
   | #python | `71.28% <85.16%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.97% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [368c85d...3c40dd7](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c117e222c09590bc56ad06ad1708e5d264b1c798&el=desc) will **decrease** coverage by `4.65%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   66.36%   -4.66%     
   ==========================================
     Files         583      583              
     Lines       30634    30670      +36     
     Branches     3165     3165              
   ==========================================
   - Hits        21758    20355    -1403     
   - Misses       8765    10134    +1369     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.31% <ø> (ø)` | |
   | #python | `71.27% <84.50%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.02% <91.66%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [150 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [c117e22...867d57f](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9824: style: enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `11.62%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9824       +/-   ##
   ===========================================
   - Coverage   70.88%   59.25%   -11.63%     
   ===========================================
     Files         585      401      -184     
     Lines       30432    12564    -17868     
     Branches     3152     3152               
   ===========================================
   - Hits        21571     7445    -14126     
   + Misses       8749     4938     -3811     
   - Partials      112      181       +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.25% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [306 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...9cea662](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/368c85de1b8fec74dc2df38df92527dede4a00c4&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `85.16%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   + Coverage   66.32%   66.33%   +0.01%     
   ==========================================
     Files         588      588              
     Lines       30786    30822      +36     
     Branches     3238     3238              
   ==========================================
   + Hits        20418    20445      +27     
   - Misses      10181    10190       +9     
     Partials      187      187              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.30% <ø> (ø)` | |
   | #python | `71.28% <85.16%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.97% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [368c85d...3c40dd7](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630415479


   @villebro thanks for the feedback. I've addressed your comments. Note https://github.com/apache/incubator-superset/pull/9833 is a prerequisite to fix the docs check which is failing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on pull request #9824: style(mypy): enforcing mypy typing for superset.connectors

Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-633678431


   LGTM after the `Union` to `Tuple` change 👍 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: chore(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r426338096



##########
File path: superset/viz.py
##########
@@ -1055,9 +1055,9 @@ def query_obj(self):
         # dedup groupby if it happens to be the same
         d["groupby"] = list(dict.fromkeys(d["groupby"]))
 
-        self.x_metric = form_data.get("x")
-        self.y_metric = form_data.get("y")
-        self.z_metric = form_data.get("size")
+        self.x_metric = form_data["x"]

Review comment:
       I perceive these are all required otherwise `utils.get_metric_name(...)` etc. would return `None` and cause issues when trying to index the Pandas DataFrame.

##########
File path: superset/connectors/sqla/models.py
##########
@@ -841,6 +858,7 @@ def get_sqla_query(  # sqla
 
         where_clause_and = []
         having_clause_and: List = []
+        assert filter

Review comment:
       Note this could be `None` per the function signature and thus line #862 would throw an exception, however to the best of my knowledge this hasn't happened and thus `filter` is probably _never_ `None`. 

##########
File path: superset/views/base.py
##########
@@ -359,19 +361,21 @@ def yaml_export(self, items):
 
 
 class DeleteMixin:  # pylint: disable=too-few-public-methods
-    def _delete(self, primary_key):
+    def _delete(
+        self: Union[BaseView, "DeleteMixin", DruidClusterModelView], primary_key: int,
+    ) -> None:
         """
             Delete function logic, override to implement diferent logic
             deletes the record with primary_key = primary_key
 
             :param primary_key:
                 record primary key to delete
         """
-        item = self.datamodel.get(primary_key, self._base_filters)
+        item = self.datamodel.get(primary_key, self._base_filters)  # type: ignore

Review comment:
       Because FAB isn't typed and there's no stubs it seems simpler to just ignore these.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c117e222c09590bc56ad06ad1708e5d264b1c798&el=desc) will **decrease** coverage by `4.69%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   66.32%   -4.70%     
   ==========================================
     Files         583      583              
     Lines       30634    30670      +36     
     Branches     3165     3165              
   ==========================================
   - Hits        21758    20343    -1415     
   - Misses       8765    10146    +1381     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.31% <ø> (ø)` | |
   | #python | `71.21% <84.50%> (-0.06%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.02% <91.66%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [153 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [c117e22...8c4c77a](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/368c85de1b8fec74dc2df38df92527dede4a00c4&el=desc) will **decrease** coverage by `0.27%`.
   > The diff coverage is `85.16%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   66.32%   66.04%   -0.28%     
   ==========================================
     Files         588      588              
     Lines       30786    30657     -129     
     Branches     3238     3238              
   ==========================================
   - Hits        20418    20247     -171     
   - Misses      10181    10223      +42     
     Partials      187      187              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `59.30% <ø> (ø)` | |
   | #python | `70.83% <85.16%> (-0.45%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.76% <40.00%> (-4.95%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.12% <41.66%> (-0.33%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.85% <90.00%> (-0.12%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.68% <95.12%> (+0.08%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [43 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [368c85d...3c40dd7](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `4.66%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   66.36%   -4.67%     
   ==========================================
     Files         583      583              
     Lines       30615    30651      +36     
     Branches     3162     3162              
   ==========================================
   - Hits        21745    20342    -1403     
   - Misses       8759    10128    +1369     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.29% <ø> (ø)` | |
   | #python | `71.27% <84.50%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.02% <91.66%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [150 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [68832d2...eef2c96](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `11.64%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9824       +/-   ##
   ===========================================
   - Coverage   70.88%   59.24%   -11.65%     
   ===========================================
     Files         585      402      -183     
     Lines       30432    12584    -17848     
     Branches     3152     3158        +6     
   ===========================================
   - Hits        21571     7455    -14116     
   + Misses       8749     4948     -3801     
   - Partials      112      181       +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.24% <ø> (-0.02%)` | :arrow_down: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [307 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...8142a6c](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #9824: style(mypy): enforcing mypy typing for superset.connectors

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r429750031



##########
File path: superset/utils/core.py
##########
@@ -985,11 +988,11 @@ def is_adhoc_metric(metric) -> bool:
     )
 
 
-def get_metric_name(metric):
-    return metric["label"] if is_adhoc_metric(metric) else metric
+def get_metric_name(metric: Metric) -> str:

Review comment:
       I agree.

##########
File path: superset/typing.py
##########
@@ -16,15 +16,31 @@
 # under the License.
 from typing import Any, Callable, Dict, List, Optional, Tuple, Union
 
-from flask import Flask
+import flask
+import werkzeug
 from flask_caching import Cache
 
-CacheConfig = Union[Callable[[Flask], Cache], Dict[str, Any]]
+CacheConfig = Union[Callable[[flask.Flask], Cache], Dict[str, Any]]
 DbapiDescriptionRow = Tuple[
     str, str, Optional[str], Optional[str], Optional[int], Optional[int], bool
 ]
 DbapiDescription = Union[List[DbapiDescriptionRow], Tuple[DbapiDescriptionRow, ...]]
 DbapiResult = List[Union[List[Any], Tuple[Any, ...]]]
 FilterValue = Union[float, int, str]
 FilterValues = Union[FilterValue, List[FilterValue], Tuple[FilterValue]]
+Granularity = Union[str, Dict[str, Union[str, float]]]
+Metric = Union[Dict[str, str], str]
+QueryObjectDict = Dict[str, Any]
 VizData = Optional[Union[List[Any], Dict[Any, Any]]]
+
+# Flask response.
+Base = Union[bytes, str]
+Status = Union[int, str]
+Headers = Dict[str, Any]
+FlaskResponse = Union[
+    flask.wrappers.Response,
+    werkzeug.wrappers.Response,
+    Base,
+    Union[Base, Status],
+    Union[Base, Status, Headers],
+]

Review comment:
       As we already have a wrapping `Union` here, couldn't this be expressed as `Union[..., Base, Status, Headers]`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley merged pull request #9824: style(mypy): enforcing mypy typing for superset.connectors

Posted by GitBox <gi...@apache.org>.
john-bodley merged pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f1208f510ceda24654dca794cf04a33aa234cc5&el=desc) will **decrease** coverage by `0.65%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.13%   70.48%   -0.66%     
   ==========================================
     Files         588      404     -184     
     Lines       30792    12741   -18051     
     Branches     3238     3238              
   ==========================================
   - Hits        21904     8980   -12924     
   + Misses       8776     3643    -5133     
   - Partials      112      118       +6     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.26% <ø> (-0.76%)` | :arrow_down: |
   | #javascript | `59.30% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
   | [superset-frontend/src/reduxUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMuanM=) | `76.47% <0.00%> (-10.30%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.03%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
   | [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (-1.29%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
   | ... and [169 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [6f1208f...6c67fde](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `4.83%`.
   > The diff coverage is `84.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   70.88%   66.04%   -4.84%     
   ==========================================
     Files         585      586       +1     
     Lines       30432    30505      +73     
     Branches     3152     3158       +6     
   ==========================================
   - Hits        21571    20148    -1423     
   - Misses       8749    10176    +1427     
   - Partials      112      181      +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.24% <ø> (-0.02%)` | :arrow_down: |
   | #python | `70.82% <84.36%> (-0.20%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.76% <40.00%> (-4.95%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.12% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.45% <88.00%> (-0.15%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.91% <91.66%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.68% <95.00%> (+0.12%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.05%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.42%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.87%)` | :arrow_up: |
   | ... and [163 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...a7e5c32](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c117e222c09590bc56ad06ad1708e5d264b1c798&el=desc) will **decrease** coverage by `4.94%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   66.07%   -4.95%     
   ==========================================
     Files         583      583              
     Lines       30634    30505     -129     
     Branches     3165     3165              
   ==========================================
   - Hits        21758    20157    -1601     
   - Misses       8765    10167    +1402     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.31% <ø> (ø)` | |
   | #python | `70.82% <84.50%> (-0.45%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.76% <40.00%> (-4.95%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.12% <41.66%> (-0.33%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.91% <91.66%> (-0.12%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.68% <95.12%> (+0.08%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [187 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [c117e22...867d57f](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/368c85de1b8fec74dc2df38df92527dede4a00c4&el=desc) will **increase** coverage by `4.80%`.
   > The diff coverage is `85.16%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   + Coverage   66.32%   71.13%   +4.80%     
   ==========================================
     Files         588      588              
     Lines       30786    30822      +36     
     Branches     3238     3238              
   ==========================================
   + Hits        20418    21924    +1506     
   + Misses      10181     8786    -1395     
   + Partials      187      112      -75     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.93% <ø> (?)` | |
   | #javascript | `59.30% <ø> (ø)` | |
   | #python | `71.28% <85.16%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.97% <90.00%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [154 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [368c85d...3c40dd7](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c117e222c09590bc56ad06ad1708e5d264b1c798&el=desc) will **decrease** coverage by `11.71%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9824       +/-   ##
   ===========================================
   - Coverage   71.02%   59.31%   -11.72%     
   ===========================================
     Files         583      399      -184     
     Lines       30634    12583    -18051     
     Branches     3165     3165               
   ===========================================
   - Hits        21758     7463    -14295     
   + Misses       8765     4939     -3826     
   - Partials      111      181       +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.31% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [304 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [c117e22...8c4c77a](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `4.54%`.
   > The diff coverage is `84.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   70.88%   66.33%   -4.55%     
   ==========================================
     Files         585      586       +1     
     Lines       30432    30670     +238     
     Branches     3152     3158       +6     
   ==========================================
   - Hits        21571    20346    -1225     
   - Misses       8749    10143    +1394     
   - Partials      112      181      +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.24% <ø> (-0.02%)` | :arrow_down: |
   | #python | `71.27% <84.36%> (+0.25%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (+0.14%)` | :arrow_up: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.45% <88.00%> (-0.15%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.02% <91.66%> (+0.11%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.00%> (+0.27%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.05%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.42%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.87%)` | :arrow_up: |
   | ... and [181 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...a7e5c32](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f1208f510ceda24654dca794cf04a33aa234cc5&el=desc) will **decrease** coverage by `11.83%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9824       +/-   ##
   ===========================================
   - Coverage   71.13%   59.30%   -11.84%     
   ===========================================
     Files         588      404      -184     
     Lines       30792    12741    -18051     
     Branches     3238     3238               
   ===========================================
   - Hits        21904     7556    -14348     
   + Misses       8776     4998     -3778     
   - Partials      112      187       +75     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.30% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [309 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [6f1208f...6c67fde](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **increase** coverage by `0.01%`.
   > The diff coverage is `83.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   + Coverage   71.02%   71.04%   +0.01%     
   ==========================================
     Files         583      583              
     Lines       30615    30653      +38     
     Branches     3162     3162              
   ==========================================
   + Hits        21745    21776      +31     
   - Misses       8759     8766       +7     
     Partials      111      111              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.62% <ø> (+0.07%)` | :arrow_up: |
   | #javascript | `59.29% <ø> (ø)` | |
   | #python | `71.27% <83.87%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.04% <92.85%> (+0.01%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [68832d2...b66071f](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for superset.connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c117e222c09590bc56ad06ad1708e5d264b1c798&el=desc) will **decrease** coverage by `11.71%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9824       +/-   ##
   ===========================================
   - Coverage   71.02%   59.31%   -11.72%     
   ===========================================
     Files         583      399      -184     
     Lines       30634    12583    -18051     
     Branches     3165     3165               
   ===========================================
   - Hits        21758     7463    -14295     
   + Misses       8765     4939     -3826     
   - Partials      111      181       +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.31% <ø> (ø)` | |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [304 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [c117e22...867d57f](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] villebro commented on a change in pull request #9824: style(mypy): enforcing mypy typing for superset.connectors

Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r430040044



##########
File path: superset/typing.py
##########
@@ -16,15 +16,31 @@
 # under the License.
 from typing import Any, Callable, Dict, List, Optional, Tuple, Union
 
-from flask import Flask
+import flask
+import werkzeug
 from flask_caching import Cache
 
-CacheConfig = Union[Callable[[Flask], Cache], Dict[str, Any]]
+CacheConfig = Union[Callable[[flask.Flask], Cache], Dict[str, Any]]
 DbapiDescriptionRow = Tuple[
     str, str, Optional[str], Optional[str], Optional[int], Optional[int], bool
 ]
 DbapiDescription = Union[List[DbapiDescriptionRow], Tuple[DbapiDescriptionRow, ...]]
 DbapiResult = List[Union[List[Any], Tuple[Any, ...]]]
 FilterValue = Union[float, int, str]
 FilterValues = Union[FilterValue, List[FilterValue], Tuple[FilterValue]]
+Granularity = Union[str, Dict[str, Union[str, float]]]
+Metric = Union[Dict[str, str], str]
+QueryObjectDict = Dict[str, Any]
 VizData = Optional[Union[List[Any], Dict[Any, Any]]]
+
+# Flask response.
+Base = Union[bytes, str]
+Status = Union[int, str]
+Headers = Dict[str, Any]
+FlaskResponse = Union[
+    flask.wrappers.Response,
+    werkzeug.wrappers.Response,
+    Base,
+    Union[Base, Status],
+    Union[Base, Status, Headers],
+]

Review comment:
       Ok, that makes sense. Unrelated comment, it's really strange how practically none of the major libraries have implemented type annotations yet. Yes, stubs exist for many, but that doesn't really help when reading code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `11.64%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #9824       +/-   ##
   ===========================================
   - Coverage   70.88%   59.24%   -11.65%     
   ===========================================
     Files         585      402      -183     
     Lines       30432    12584    -17848     
     Branches     3152     3158        +6     
   ===========================================
   - Hits        21571     7455    -14116     
   + Misses       8749     4948     -3801     
   - Partials      112      181       +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.24% <ø> (-0.02%)` | :arrow_down: |
   | #python | `?` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [307 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...eef8562](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c117e222c09590bc56ad06ad1708e5d264b1c798&el=desc) will **decrease** coverage by `4.69%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   66.32%   -4.70%     
   ==========================================
     Files         583      583              
     Lines       30634    30670      +36     
     Branches     3165     3165              
   ==========================================
   - Hits        21758    20343    -1415     
   - Misses       8765    10146    +1381     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.31% <ø> (ø)` | |
   | #python | `71.21% <84.50%> (-0.06%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.02% <91.66%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [153 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [c117e22...867d57f](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6f1208f510ceda24654dca794cf04a33aa234cc5&el=desc) will **decrease** coverage by `0.11%`.
   > The diff coverage is `83.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.13%   71.01%   -0.12%     
   ==========================================
     Files         588      588              
     Lines       30792    30665     -127     
     Branches     3238     3238              
   ==========================================
   - Hits        21904    21778     -126     
     Misses       8776     8776              
   + Partials      112      111       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `54.05% <ø> (+0.02%)` | :arrow_up: |
   | #javascript | `59.30% <ø> (ø)` | |
   | #python | `71.05% <83.87%> (-0.22%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.12% <41.66%> (-0.33%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.92% <92.85%> (-0.11%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [35 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [6f1208f...6c67fde](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c117e222c09590bc56ad06ad1708e5d264b1c798&el=desc) will **decrease** coverage by `4.65%`.
   > The diff coverage is `84.50%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   66.36%   -4.66%     
   ==========================================
     Files         583      583              
     Lines       30634    30670      +36     
     Branches     3165     3165              
   ==========================================
   - Hits        21758    20355    -1403     
   - Misses       8765    10134    +1369     
   - Partials      111      181      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.31% <ø> (ø)` | |
   | #python | `71.27% <84.50%> (+<0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.02% <91.66%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [150 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [c117e22...8c4c77a](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629827050


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/53b58edd6ff759c87ea177b157206e1024c7629a&el=desc) will **decrease** coverage by `4.73%`.
   > The diff coverage is `84.36%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   70.88%   66.14%   -4.74%     
   ==========================================
     Files         585      586       +1     
     Lines       30432    30505      +73     
     Branches     3152     3158       +6     
   ==========================================
   - Hits        21571    20177    -1394     
   - Misses       8749    10147    +1398     
   - Partials      112      181      +69     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.24% <ø> (-0.02%)` | :arrow_down: |
   | #python | `70.98% <84.36%> (-0.04%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.12% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.45% <88.00%> (-0.15%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.91% <91.66%> (ø)` | |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.00%> (+0.27%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.05%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.42%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.87%)` | :arrow_up: |
   | ... and [156 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [53b58ed...a7e5c32](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-630573982


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=h1) Report
   > Merging [#9824](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `0.23%`.
   > The diff coverage is `83.87%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9824/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9824      +/-   ##
   ==========================================
   - Coverage   71.02%   70.78%   -0.24%     
   ==========================================
     Files         583      583              
     Lines       30615    30653      +38     
     Branches     3162     3162              
   ==========================================
   - Hits        21745    21699      -46     
   - Misses       8759     8836      +77     
   - Partials      111      118       +7     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `52.80% <ø> (-0.75%)` | :arrow_down: |
   | #javascript | `59.29% <ø> (ø)` | |
   | #python | `71.20% <83.87%> (-0.07%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `81.73% <40.00%> (-3.99%)` | :arrow_down: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `73.36% <41.66%> (-0.09%)` | :arrow_down: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.47% <88.00%> (-0.21%)` | :arrow_down: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `72.04% <92.85%> (+0.01%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.83% <95.12%> (+0.23%)` | :arrow_up: |
   | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.11% <100.00%> (-0.35%)` | :arrow_down: |
   | [superset/connectors/base/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL3ZpZXdzLnB5) | `75.00% <100.00%> (+3.57%)` | :arrow_up: |
   | [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `68.91% <100.00%> (+0.21%)` | :arrow_up: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `77.86% <100.00%> (+0.34%)` | :arrow_up: |
   | ... and [20 more](https://codecov.io/gh/apache/incubator-superset/pull/9824/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=footer). Last update [68832d2...b66071f](https://codecov.io/gh/apache/incubator-superset/pull/9824?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #9824: style(mypy): enforcing mypy typing for superset.connectors module

Posted by GitBox <gi...@apache.org>.
serenajiang commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r434251806



##########
File path: superset/utils/core.py
##########
@@ -256,8 +259,6 @@ def parse_human_datetime(s: Optional[str]) -> Optional[datetime]:
     >>> year_ago_1 == year_ago_2
     True
     """
-    if not s:

Review comment:
       FOUND IT. @john-bodley 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9824: style(mypy): enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#discussion_r426868698



##########
File path: superset/connectors/druid/models.py
##########
@@ -817,7 +829,7 @@ def granularity(
             "year": "P1Y",
         }
 
-        granularity: Dict[str, Union[str, float]] = {"type": "period"}
+        granularity = {"type": "period"}

Review comment:
       @villebro I guess it differs from the `Granularity` type which I defined previously (which adds to the confusion). When including the typing here it causes a conflict with the return type as it can also be a string per line 812. 
   
   A couple of learnings from having typed a bunch of Python code: 
   
   1. `Optional[...]` values are difficult to handle and thus should be avoided if possible. It seems they're often used by laziness. 
   2. Mixed types, i.e., those requiring a `Union[...]` normally indicates poor quality and unnecessarily complex code. 
   
   I think the return type of `granularity` is a clear indication of (2). Also I believe the true return type should be `Union[Dict[str, Union[str, float]], str]` but `mypy` complains on this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] john-bodley commented on pull request #9824: style: enforcing mypy typing for connectors

Posted by GitBox <gi...@apache.org>.
john-bodley commented on pull request #9824:
URL: https://github.com/apache/incubator-superset/pull/9824#issuecomment-629833865


   @villebro I started out thinking this would be a somewhat mindless/trivial change to kill some time whilst sheltering-in-place. It definitely became more complex/tedious than I initially had hoped.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org