You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Alex Karasulu <ak...@apache.org> on 2008/05/15 12:14:13 UTC

Re: svn commit: r656527 - in /directory/apacheds/branches/bigbang: core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.ja

Felix you're absolutely right - there's also the option of setting the cause
after instantiating before throwing.  That's what I usually do but I was
rushing to fix this to get some sleep :).

I'll fix it.

Thanks,
Alex

On Thu, May 15, 2008 at 3:21 AM, Felix Knecht <fe...@apache.org> wrote:

> Hi Alex
>
> Your loosing information about e.g. the class not found this way.
> I'd propose something like
>
> catch ( ClassNotFoundException e )
> {
>   throw new IOException( "Could not find class. " + e.getMessage( ) );
> }
>
>
> Regards
> Felix
>
>
>
>  Author: akarasulu
>> Date: Thu May 15 00:16:28 2008
>> New Revision: 656527
>>
>> URL: http://svn.apache.org/viewvc?rev=656527&view=rev
>> Log:
>> make it work with jdk 5
>>
>> Modified:
>>
>>  directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java
>>
>>  directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java
>>
>> Modified:
>> directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java
>> URL:
>> http://svn.apache.org/viewvc/directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java?rev=656527&r1=656526&r2=656527&view=diff
>>
>> ==============================================================================
>> ---
>> directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java
>> (original)
>> +++
>> directory/apacheds/branches/bigbang/core-avl/src/main/java/org/apache/directory/server/core/avltree/DefaultMarshaller.java
>> Thu May 15 00:16:28 2008
>> @@ -61,7 +61,7 @@
>>         }
>>         catch ( ClassNotFoundException e )
>>         {
>> -            throw new IOException( "Could not find class", e );
>> +            throw new IOException( "Could not find class" );
>>         }
>>           return object;
>>
>> Modified:
>> directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java
>> URL:
>> http://svn.apache.org/viewvc/directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java?rev=656527&r1=656526&r2=656527&view=diff
>>
>> ==============================================================================
>> ---
>> directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java
>> (original)
>> +++
>> directory/apacheds/branches/bigbang/jdbm-store/src/main/java/org/apache/directory/server/core/partition/impl/btree/jdbm/JdbmIndex.java
>> Thu May 15 00:16:28 2008
>> @@ -176,7 +176,7 @@
>>         }
>>         catch ( NamingException e )
>>         {
>> -            throw new IOException( "Failed to find an equality matching
>> rule for attribute type", e );
>> +            throw new IOException( "Failed to find an equality matching
>> rule for attribute type" );
>>         }
>>           /*
>>
>>
>>
>>
>
>