You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/03 14:11:10 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request #1868: Core: Add table properties for snapshot retention
aokolnychyi opened a new pull request #1868:
URL: https://github.com/apache/iceberg/pull/1868
This PR adds table properties for snapshot retention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1868: Core: Add table properties for snapshot retention
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #1868:
URL: https://github.com/apache/iceberg/pull/1868#discussion_r535258124
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -140,4 +140,10 @@ private TableProperties() {
public static final String GC_ENABLED = "gc.enabled";
public static final boolean GC_ENABLED_DEFAULT = true;
+
+ public static final String MAX_SNAPSHOT_AGE_MS = "history.expire.max-snapshot-age-ms";
+ public static final long MAX_SNAPSHOT_AGE_MS_DEFAULT = 5 * 24 * 60 * 60 * 1000; // 5 days
+
+ public static final String RETAIN_MIN_NUM_SNAPSHOTS = "history.expire.retain-min-num-snapshots";
+ public static final int RETAIN_MIN_NUM_SNAPSHOTS_DEFAULT = 1;
Review comment:
This is not a particularly good default but we need it to keep the old behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1868: Core: Add table properties for snapshot retention
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1868:
URL: https://github.com/apache/iceberg/pull/1868
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1868: Core: Add table properties for snapshot retention
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1868:
URL: https://github.com/apache/iceberg/pull/1868#issuecomment-738247716
Merged. Thanks for working on this, @aokolnychyi!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1868: Core: Add table properties for snapshot retention
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1868:
URL: https://github.com/apache/iceberg/pull/1868#discussion_r535449359
##########
File path: site/docs/configuration.md
##########
@@ -81,6 +81,8 @@ Iceberg tables support table properties to configure table behavior, like the de
| commit.manifest.target-size-bytes | 8388608 (8 MB) | Target size when merging manifest files |
| commit.manifest.min-count-to-merge | 100 | Minimum number of manifests to accumulate before merging |
| commit.manifest-merge.enabled | true | Controls whether to automatically merge manifests on writes |
+| history.expire.max-snapshot-age-ms | 432000000 (5 days) | Default max age of snapshots to keep while expiring snapshots |
+| history.expire.retain-min-num-snapshots | 1 | Default min number of snapshots to keep while expiring snapshots |
Review comment:
What do you think about a slight rename so that `min` comes first and we remove `num`? I'm thinking `history.expire.min-retained-snapshots`. We could also use `kept` instead of `retained` if that is more clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1868: Core: Add table properties for snapshot retention
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #1868:
URL: https://github.com/apache/iceberg/pull/1868#discussion_r535258124
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -140,4 +140,10 @@ private TableProperties() {
public static final String GC_ENABLED = "gc.enabled";
public static final boolean GC_ENABLED_DEFAULT = true;
+
+ public static final String MAX_SNAPSHOT_AGE_MS = "history.expire.max-snapshot-age-ms";
+ public static final long MAX_SNAPSHOT_AGE_MS_DEFAULT = 5 * 24 * 60 * 60 * 1000; // 5 days
+
+ public static final String RETAIN_MIN_NUM_SNAPSHOTS = "history.expire.retain-min-num-snapshots";
+ public static final int RETAIN_MIN_NUM_SNAPSHOTS_DEFAULT = 1;
Review comment:
This is not a particularly good default but we need it to keep the old behavior by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org