You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/02/17 21:30:01 UTC
incubator-zeppelin git commit: Fix broken form of keyboard shortcut
modal page
Repository: incubator-zeppelin
Updated Branches:
refs/heads/master 8e46b0a46 -> 2f737121e
Fix broken form of keyboard shortcut modal page
### What is this PR for?
Fix broken form of keyboard shortcut help modal
### Is there a relevant Jira issue? No
### Screenshots (if appropriate)
**Before**
![screen shot 2016-02-15 at 1 05 49 pm](https://cloud.githubusercontent.com/assets/8503346/13039639/e4f3d6ba-d3e4-11e5-8239-a2b931a17305.png)
**After**
![screen shot 2016-02-15 at 1 05 40 pm](https://cloud.githubusercontent.com/assets/8503346/13039640/e4f42d04-d3e4-11e5-9be5-ec6ae58b8835.png)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Mina Lee <mi...@nflabs.com>
Closes #715 from minahlee/fix/keyboardShortcutHelp and squashes the following commits:
eab10c1 [Mina Lee] Change Alt to be Option in Mac
1b684ca [Mina Lee] Fix broken form of keyboard shortcut modal page
Project: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/commit/2f737121
Tree: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/tree/2f737121
Diff: http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/diff/2f737121
Branch: refs/heads/master
Commit: 2f737121e85ba5c9e23fcd078cd42f5d5420e2ab
Parents: 8e46b0a
Author: Mina Lee <mi...@nflabs.com>
Authored: Wed Feb 17 11:19:39 2016 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Wed Feb 17 12:33:25 2016 -0800
----------------------------------------------------------------------
zeppelin-web/src/components/modal-shortcut/modal-shortcut.html | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-zeppelin/blob/2f737121/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html b/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html
index 863d7dd..c07f5e0 100644
--- a/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html
+++ b/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html
@@ -125,8 +125,7 @@ limitations under the License.
<div class="row">
<div class="col-md-4">
<div class="keys">
- <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">{{ isMac ? 'Option' : 'Alt'}}</kbd> + <kbd class="kbd-dark">o</kbd>
- <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">Alt</kbd> + <kbd class="kbd-dark">r</kbd>
+ <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">{{ isMac ? 'Option' : 'Alt' }}</kbd> + <kbd class="kbd-dark">r</kbd>
</div>
</div>
<div class="col-md-8">
@@ -137,7 +136,7 @@ limitations under the License.
<div class="row">
<div class="col-md-4">
<div class="keys">
- <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">{ isMac ? 'Option' : 'Alt'}}</kbd> + <kbd class="kbd-dark">o</kbd>
+ <kbd class="kbd-dark">Ctrl</kbd> + <kbd class="kbd-dark">{{ isMac ? 'Option' : 'Alt'}}</kbd> + <kbd class="kbd-dark">o</kbd>
</div>
</div>
<div class="col-md-8">