You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ho...@apache.org on 2014/02/15 22:58:58 UTC
svn commit: r1568690 -
/lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java
Author: hossman
Date: Sat Feb 15 21:58:58 2014
New Revision: 1568690
URL: http://svn.apache.org/r1568690
Log:
SOLR-5652: remove doc details logging now that we've identified hte original codec problem with the test
Modified:
lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java
Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java?rev=1568690&r1=1568689&r2=1568690&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/cloud/DistribCursorPagingTest.java Sat Feb 15 21:58:58 2014
@@ -532,15 +532,11 @@ public class DistribCursorPagingTest ext
}
commit();
- log.info("SOLR-5652: Begining Loop over smallish num of docs");
- final boolean SOLR_5652 = true;
-
for (String f : allFieldNames) {
for (String order : new String[] {" asc", " desc"}) {
String sort = f + order + ("id".equals(f) ? "" : ", id" + order);
String rows = "" + _TestUtil.nextInt(random(),13,50);
- SentinelIntSet ids = assertFullWalkNoDups(SOLR_5652,
- numInitialDocs,
+ SentinelIntSet ids = assertFullWalkNoDups(numInitialDocs,
params("q", "*:*",
"fl","id,"+f,
"rows",rows,
@@ -573,8 +569,6 @@ public class DistribCursorPagingTest ext
}
}
- log.info("SOLR-5652: Ending Loop over smallish num of docs");
-
// now add a lot more docs, and test a handful of randomized multi-level sorts
for (int i = numInitialDocs+1; i <= totalDocs; i++) {
SolrInputDocument doc = CursorPagingTest.buildRandomDocument(i);
@@ -710,13 +704,6 @@ public class DistribCursorPagingTest ext
* </p>
*/
public SentinelIntSet assertFullWalkNoDups(int maxSize, SolrParams params) throws Exception {
- return assertFullWalkNoDups(false, maxSize, params);
- }
-
- /** :TODO: refactor method into two arg version once SOLR-5652 is resolved */
- private SentinelIntSet assertFullWalkNoDups(final boolean verbose,
- final int maxSize,
- final SolrParams params) throws Exception {
SentinelIntSet ids = new SentinelIntSet(maxSize, -1);
String cursorMark = CURSOR_MARK_START;
int docsOnThisPage = Integer.MAX_VALUE;
@@ -736,16 +723,6 @@ public class DistribCursorPagingTest ext
cursorMark, nextCursorMark);
}
- if (verbose) { // SOLR-5652
- // SolrDocument is a bit more verbose then we need
- StringBuilder s = new StringBuilder();
- for (SolrDocument doc : docs) {
- s.append(doc.getFieldValuesMap().toString());
- s.append("; ");
- }
- log.info("SOLR-5652: ({}) gave us these docs: {}", p, s);
- }
-
for (SolrDocument doc : docs) {
int id = ((Integer)doc.get("id")).intValue();
if (ids.exists(id)) {